Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TODO at fileSystem#89 #188

Open
atherdon opened this issue Jul 23, 2019 · 11 comments
Open

Fix TODO at fileSystem#89 #188

atherdon opened this issue Jul 23, 2019 · 11 comments
Assignees

Comments

@atherdon
Copy link
Contributor

Strings must use singlequote.

https://codeclimate.com/github/GroceriStar/food-static-files-generator/src/measurements.js#issue_5d3789ba3908c50001000088

@atherdon
Copy link
Contributor Author

@ijb87 another small task

@ijb87
Copy link
Contributor

ijb87 commented Sep 17, 2019

i don't see the measurements.js file in the src folder

@atherdon
Copy link
Contributor Author

yeah, we moved out that files to projects3.0 folder.

for now @ijb87 you can fix this todo: https://github.com/GroceriStar/food-static-files-generator/blob/master/src/fileSystem.js#L89

@atherdon
Copy link
Contributor Author

@ijb87 tell me if you started this task - because now we merged new chances and code line can change a bit

@atherdon atherdon changed the title Fix "quotes" issue in src/measurements.js Fix TODO at fileSystem#89 Sep 20, 2019
@ijb87
Copy link
Contributor

ijb87 commented Sep 21, 2019

haven't started on it yet...I just remembered xD i'll start working on it, but to be clear, the task is to improve the getFileName method by shortening it?

@atherdon
Copy link
Contributor Author

@ijb87 emm, nope.

At method save you should replace the default loop with a method from lodash library. for sure it should work after changes. you can also make more changes if you wish but be careful

@ijb87
Copy link
Contributor

ijb87 commented Sep 24, 2019

@atherdon what do you mean by:

// - we just need to find a better way to rewrite a getFileName method

@atherdon
Copy link
Contributor Author

@ijb87 it's hard to explain :)
when I see that code - it's not perfect - my gut tells me that.
show me few code changes and if it will require changes - i'll tell you.

again - everything here is related to pull requests - if you start something - that show me and I will be able to guide you forward

@ijb87
Copy link
Contributor

ijb87 commented Oct 3, 2019

@atherdon I don't think I have permission to pull request...

@atherdon
Copy link
Contributor Author

atherdon commented Oct 3, 2019

hmm, you should have a forked repository - and you'll have ability to open pull requests

@atherdon
Copy link
Contributor Author

atherdon commented Oct 3, 2019

I even don't see this repository on your account, so please fork this repo first, then checkout it locally and then start to make your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants