-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TODO at fileSystem#89 #188
Comments
@ijb87 another small task |
i don't see the measurements.js file in the src folder |
yeah, we moved out that files to projects3.0 folder. for now @ijb87 you can fix this todo: https://github.com/GroceriStar/food-static-files-generator/blob/master/src/fileSystem.js#L89 |
@ijb87 tell me if you started this task - because now we merged new chances and code line can change a bit |
haven't started on it yet...I just remembered xD i'll start working on it, but to be clear, the task is to improve the getFileName method by shortening it? |
@ijb87 emm, nope. At method |
@atherdon what do you mean by:
|
@ijb87 it's hard to explain :) again - everything here is related to pull requests - if you start something - that show me and I will be able to guide you forward |
@atherdon I don't think I have permission to pull request... |
hmm, you should have a forked repository - and you'll have ability to open pull requests |
I even don't see this repository on your account, so please fork this repo first, then checkout it locally and then start to make your changes |
Strings must use singlequote.
https://codeclimate.com/github/GroceriStar/food-static-files-generator/src/measurements.js#issue_5d3789ba3908c50001000088
The text was updated successfully, but these errors were encountered: