projects3.0 evolution from projects2.0

[atherdon]

Main purpose is to go away from old and stupid es5 version ~~ projects2.0
because we keeping all projects in one folder just for now, so our team
members were less confused.
I think one of our goals is to create a microservice with CSV parser that
will run on Heroku so anyone can parse their stuff when he wants.
And clean up and code upgrade will really help and our project will go to a
next evolutionary step

You'll easily get used to it. I tried to reduce every problem that we have
with projects2.0, so you'll get into it pretty quick I guess.
Because we just cleaning up - not creating from scratch :)

Originally posted by @atherdon in #208 (comment)

[atherdon]

Now I'm updating generator module at our csv-parser module and will release a new version on npm.
then we'll be able to upgrade it on projects3.0

[atherdon]

@EbrahimKreem @sibasish14 @saphal1998 I think this video will be pretty useful for you.
https://www.loom.com/share/03c161e2231e45469075bad1e83cdf07

Btw, @vadim9999 do you interested to jump into it? if yes - please buzz me and we'll see what we need to do

[atherdon]

Hi everyone, i have one idea about what simple move we can do.
as we have csv datasets at projects3.0 would it be wise to remove the same data from projects2.0?
it can be a problem for fixing our small bugs, but it can move slowly as forward ;)

[atherdon]

@sibasish14 did you watch that video, right?
i made some changes recently, can you sync your fork with changes from master and check how projects3.0 works inside?
I can give you a proper task, but want you to explore it and try to find something that you can do - any simple thing is ok

[sibasish14]

@atherdon Yes, I went through the video. I think it would be nice if you assigned me a task. That way I would proceed as per the goals. Also, I think I will understand the codebase better that way.

[atherdon]

@sibasish14 As I think @EbrahimKreem is working with FAO dataset right now - the easiest way will be to separate projects between few people. l think you should jump into projects3.0/FoodComposition and try to launch it. i'm sure it will generate some errors. and our goal will be to move FoodComposition to work from proj2.0 to project3.0 structure. tell me if this make sence

[sibasish14]

Sorry I am a bit late.
Can you please explain how can I launch it?

[atherdon]

no problem at all. if i get your question correctly, you should go into projects3.0/FoodCom..
then run yarn install - it will install fresh packages and start a build process first time. I assume that build went wrong and show you some errors. you can put them here with screenshot or try to solve it by yourself by comparing code inside of that project with code related to other 3.0 projects

[atherdon]

as we made all datasets code at 2.0 working in the same logic/way - now our goal to make it work in more proper, but similar way. don't worry - it's easy

[sibasish14]

I am getting the following output after doing npm install in projects3.0/FoodComposition

[atherdon]

can you try `yarn build`? but looks like it doen't generate any issue - which is cool but strange :) if build working well too - we can move forward and try to remove/replace old FoodComposition script with a this version. but we should do it slowly :)

…

[sibasish14]

I did yarn build:

[atherdon]

ok, then go to fao project and see what Ebrahim did there in order to make parser work, i think there is no huge chnages will be necessary @sibasish14

[atherdon]

@sibasish14 please check this video https://www.loom.com/share/606346ba1b814243a5a1ae589e4468e9

[sibasish14]

I was solving as per the changes made in the FAO. I copied the contents of the index.js file from the FAO folder to the FoodComposition folder. When I tried to commit, I received a lot of linting errors:

I'll make a PR once I fix these errors.

[atherdon]

cool - @sibasish14 - for constants - you can just comment them. i want to improve our system while ago with this contants, but don't have time to perfect it.
Btw, I think we'll have similar issues with other projects as well

[sibasish14]

I fixed most of them. Can you help me fix the rest? I don't understand how to solve the rest.

[atherdon]

can you compare code at src folder with code from other projects as well?

[atherdon]

maybe it can help a bit.

what do you think about utils.js file inside of this project? are we using metohds from it? if no - just comment them. all of them

[atherdon]

about file csv_parser - i think it's just an old rudiment - we don't need it to make everything work - because our separated module published at npm and can be installed in a correct way

[sibasish14]

Now there is only one error left:
/home/sibasish/GroceriStar/food-datasets-csv-parser/projects3.0/FoodComposition/src/index.js

44:13 error Unable to resolve path to module '../../../package/dist/index.cjs' import/no-unresolved

I figured that there's no dist folder in the package directory. How do I fix it?

[ebrahim-2]

rather than referencing the dist folder you can use the npm module ex:
const { findCsvFiles, parseCsv, csvToJson } = require("@groceristar/food-dataset-csv-parser")

[ebrahim-2]

I figured that there's no dist folder in the package directory. How do I fix it?

if you want to make a dist folder for development purposes:
1- cd package
2- npm run dev

[atherdon]

i don't think that using dev way is a good way. i mean it better to submit pr for module - then i'm publishing it and we test if it work - because working through `dist` - it's like trying to eat raw coffee without using water :)

…

[hanroro]

@atherdon Should I work on Restaurants folder for the same thing?

[atherdon]

@hanroro good idea - pursue it!

[hanroro]

@atherdon Just submitted two PR for USFA and Restaurants. Please have a check.

[atherdon]

does restaurants dataset parsed and generating json under projects3.0 folder? if yes- then we can kill restaurants folder at projects2.0 - correct? if yes - please do - let's clean it up a bit

…

[hanroro]

does restaurants dataset parsed and generating json under projects3.0 folder? if yes- then we can kill restaurants folder at projects2.0 - correct? if yes - please do - let's clean it up a bit
…

From the codes I added. I think it do parse, but I do not know where the output is located and it seems there is not any file created. So how can i check that?

[atherdon]

buzz Ebrahim here, because he made that code. in mean time you can check if we have an explanation at readme. if no - we'll need to add it there, because someone else can be confused as well

…

[ebrahim-2]

that's why I opened #262 @hanroro we will fix it soon at the mean time you can test it manually ex:

cd projects3.0/folderName/src
node index.js

[atherdon]

guys, i made some changes in our repo - please sync your forks with master branch

[atherdon]

@sainiyash2903 jump here- into the action :)

[yashaswisaini]

@atherdon Now a days, my examinations are going on. So, I'm little bit busy . I will be in action from 9 December.

[atherdon]

sure sure

[atherdon]

@sainiyash2903 jump here. we'll clean up this module with you

[yashaswisaini]

@atherdon I need your guidance, in my work . I don't know what to do . Everything is new for me . I'm learning React side by side.

[atherdon]

@sainiyash2903 sure, but part of my goal here is to see how you "act" in the open ocean. I mean yes I can guide you - but did you go through our conversations and explore it on your own?
Again - this code is simple - you just need to break this first wall :)

I always have this example: most of the peoples cant do 30 pull-ups - because it's hard and they not trained well. But what if someone will stand behind you with a rifle. and if you don't do it - they will shoot. I assure you - people will have better results in the second case.
So I'm waiting for a more detailed question from you. Or just go at code and try to break something and show it to us :)