Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeclimate warnings after PR#114 #117

Open
atherdon opened this issue Aug 23, 2019 · 2 comments
Open

Codeclimate warnings after PR#114 #117

atherdon opened this issue Aug 23, 2019 · 2 comments

Comments

@atherdon
Copy link
Collaborator

i'm ready to merge it, but check codeclimate report https://codeclimate.com/github/GroceriStar/food-datasets-csv-parser/pull/114

Originally posted by @atherdon in #114 (comment)

as I think some issues was not addressed - we'll need to handle it as well
@SyeedHasan

@atherdon atherdon changed the title i'm ready to merge it, but check codeclimate report https://codeclimate.com/github/GroceriStar/food-datasets-csv-parser/pull/114 Codeclimate warnings after PR#114 Aug 23, 2019
@atherdon
Copy link
Collaborator Author

i didn't review all of them, but we can discuss them here.
I assume we can solve some of that problems

@atherdon
Copy link
Collaborator Author

The main issue with these notifications - they tend to be collected and later it's hard to solve them in bulk. This is why it better to address them now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant