Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client doesn't disconnect upon connection-loss #35

Open
Cyclone47 opened this issue Jul 31, 2018 · 3 comments
Open

Client doesn't disconnect upon connection-loss #35

Cyclone47 opened this issue Jul 31, 2018 · 3 comments

Comments

@Cyclone47
Copy link
Collaborator

When your connection (to the server) breaks the chatclient stays open and doesn't update anymore.
Need some sort of keep-alive ping to verify if the connection to the server is still available. -> If not, return to login form and show disconnected popup.

@Terrorblade
Copy link
Collaborator

We already send the keep alive packet, just need to set a connection timeout.

@Tashla
Copy link
Collaborator

Tashla commented Aug 2, 2018

Implemented in Commit 18d01f6

@Tashla Tashla closed this as completed Aug 2, 2018
@Terrorblade Terrorblade reopened this Aug 2, 2018
@StackerDEV
Copy link
Collaborator

StackerDEV commented Aug 3, 2018

Setting missing in app.setting..

I have added a feature for this. I have tested this. I don't see why it would not work. Make sure your app settings is updated and if settings change no errors occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants