Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating connection #109

Closed
MaiaLucas opened this issue Jan 15, 2025 · 9 comments · Fixed by #110
Closed

Rotating connection #109

MaiaLucas opened this issue Jan 15, 2025 · 9 comments · Fixed by #110
Assignees
Labels
enhancement New feature or request

Comments

@MaiaLucas
Copy link

MaiaLucas commented Jan 15, 2025

Description

Behaviour:

When I've tried to connect a node from the left to right the connection with fType equals to segment the fMarker(end) is always facing down.

Expected:

I would have a usecase where the marker of a connection when the connectionType is segment should be possible to be rotated when it's near a node, similar to snap connection with the same type.

Use Case example

  • Blue arrow -> snap connection
  • Grey arrow -> create connection
    image

Example of the problem

image

Additional Context

No response

@MaiaLucas MaiaLucas added the enhancement New feature or request label Jan 15, 2025
@siarheihuzarevich
Copy link
Member

Hello. The best I can do is give you a parameter to fConnectionForCreate which you could pass top, bottom, right or left!
Is it ok for you?

@MaiaLucas
Copy link
Author

MaiaLucas commented Jan 15, 2025

Hello. The best I can do is give you a parameter to fConnectionForCreate which you could pass top, bottom, right or left! Is it ok for you?

But is there any chance to the connection detect where it'll be connected? Like if I drag the connection near to an input connector on the right, the arrow turn to left and vice versa.

Because similar behaviour already exists in the snap connection.

@siarheihuzarevich
Copy link
Member

Yes. OK. I'll think about it

@siarheihuzarevich
Copy link
Member

siarheihuzarevich commented Jan 15, 2025

OK. I'll update the library tomorrow or Friday. Here is an example of work

2025-01-15.17.41.29.mov

@MaiaLucas
Copy link
Author

OK. I'll update the library tomorrow or Friday. Here is an example of work

2025-01-15.17.41.29.mov

Great! Will it work with the reassign connection too?

@anderson-896
Copy link

I also need this improvement. Thank you!

@github-project-automation github-project-automation bot moved this to Backlog in FFlow Jan 16, 2025
@siarheihuzarevich siarheihuzarevich moved this from Backlog to Ready to DEV in FFlow Jan 16, 2025
@siarheihuzarevich siarheihuzarevich linked a pull request Jan 16, 2025 that will close this issue
@siarheihuzarevich
Copy link
Member

@anderson-896 @MaiaLucas I updated the library. The functionality you need is available in version 17.0.7. I also have a favor to ask of you. Could you check if you have the same problems as described here? #108

@github-project-automation github-project-automation bot moved this from Ready to DEV to Done in FFlow Jan 16, 2025
@anderson-896
Copy link

@siarheihuzarevich I was able to reproduce here https://stackblitz.com/edit/stackblitz-starters-ykgm76ue?file=src%2Fmain.ts
for so you need to:
1 - Move any node and release the mouse;
2 - Immediately after release the mouse (should be fast) drag on the flow background (to change the flow position)

Expected behaviour:
2 - The flow moves along drag Immediately;

Current behaviour:
2 - The flow delays starting moving.

@siarheihuzarevich
Copy link
Member

@anderson-896 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants