-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Zygote.forwarddiff to ZygoteRules.forwarddiff? #9
Comments
And maybe the same for |
I think ZygoteRules should really be the bare minimum to add rules to Zygote, otherwise it will discourage people from depending on it. But perhaps we could have something like a ZygoteUtils package that has these in. |
But |
But based on the discussion in FluxML/Zygote.jl#716, I guess ChainRulesCore would probably the best place for it, so users can prepare their functions for autodiff in an engine-independent way? I'll close this issue here. |
Would it be possible to have the
forwarddiff
wrapper/hint in ZygoteRules instead of Zygote, to allow developers to include mixed-mode-diff hinting in functions without depending on Zygote?The text was updated successfully, but these errors were encountered: