Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support in layer for arbitrary graph types and use only FeaturedGraphs #201

Closed
CarloLucibello opened this issue Jul 20, 2021 · 1 comment · Fixed by #203
Closed

Comments

@CarloLucibello
Copy link
Member

Currently, layer constructors support adjacency matrices, adj lists, lightgraphs's graphs, metagraphs, abstract graphs ...
and this produces a lot of boilerplate code and sometimes performance problems. Moreover, there is little transparency about the conversions going on internally.

Since it is quite easy to create a FeaturedGraph from any other graph type, let's have the users transparently do that,
so that the gnn layers have to interact only with a single graph type fully under our control.

@yuehhua
Copy link
Member

yuehhua commented Jul 20, 2021

Dropping support for arbitrary graph types in layer constructors is fine to me.

In the original design, I would like to avoid redundant computation of the same graph structure. Keep the graph structure static in layer can save some effort for converting graph formats and calculation of Laplacian matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants