Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit GCNConv implementation #197

Open
CarloLucibello opened this issue Jul 19, 2021 · 2 comments
Open

revisit GCNConv implementation #197

CarloLucibello opened this issue Jul 19, 2021 · 2 comments

Comments

@CarloLucibello
Copy link
Member

Currently, the GCNConv implementation computes in each forward a dense Laplacian matrix for the graph.
This doesn't scale well for large graphs.
The layer should implement neighborhood aggregation and become a MessagePassing layer instead

@yuehhua
Copy link
Member

yuehhua commented Jul 20, 2021

In the forward of GCNConv layer, an algebraic computation is required, instead of implementing indexing-purposed neighborhood aggregation and a MessagePassing.
To be honest, the use of message-passing scheme is not suitable for this kind of GNN layers and the implementation in pytorch geometric doesn't benefit for computation efficiency. The approach that pytorch geometric take is just force filling GCNConv layer in the message-passing scheme, which is totally not required.
Not only GCNConv layers but also ChebConv layers require algebraic computation, not indexing neighbors.

@yuehhua
Copy link
Member

yuehhua commented Jul 20, 2021

Instead, consider scaling to large graph, a sparse array support should be considered. A sparse adjacency matrix should be accepted as a graph representation and sparse computation over CPU and GPU should also supported. For extremely large case, distributed computing should be considered. For example, Alibaba develops a distributed graph deep learning framework for recommendation systems.

@CarloLucibello CarloLucibello mentioned this issue Jul 29, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants