From f2998cf5e6c8ec8e333b88f741c9436df77a2960 Mon Sep 17 00:00:00 2001 From: Elliot Saba Date: Tue, 30 Nov 2021 17:04:34 -0800 Subject: [PATCH 1/2] Simplify mse() to use `abs2()` This simplifies the implementation of `mse()` a bit. --- src/losses/functions.jl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/losses/functions.jl b/src/losses/functions.jl index a4db0de7c3..2fc9321a47 100644 --- a/src/losses/functions.jl +++ b/src/losses/functions.jl @@ -44,8 +44,7 @@ julia> Flux.mse(y_model, y_true) """ function mse(ŷ, y; agg = mean) _check_sizes(ŷ, y) - error = ŷ .- y - real(agg(error .* conj(error))) + agg(abs2.(ŷ .- y))) end """ From 73cb9057a4a30a0429f154fb42aa011c8186f16a Mon Sep 17 00:00:00 2001 From: Elliot Saba Date: Wed, 1 Dec 2021 08:31:34 -0800 Subject: [PATCH 2/2] Remove extra parenthesis --- src/losses/functions.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/losses/functions.jl b/src/losses/functions.jl index 2fc9321a47..ff5f23a715 100644 --- a/src/losses/functions.jl +++ b/src/losses/functions.jl @@ -44,7 +44,7 @@ julia> Flux.mse(y_model, y_true) """ function mse(ŷ, y; agg = mean) _check_sizes(ŷ, y) - agg(abs2.(ŷ .- y))) + agg(abs2.(ŷ .- y)) end """