Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two-arg update!(x, d) is never used #1860

Open
cossio opened this issue Feb 4, 2022 · 0 comments
Open

Two-arg update!(x, d) is never used #1860

cossio opened this issue Feb 4, 2022 · 0 comments

Comments

@cossio
Copy link
Contributor

cossio commented Feb 4, 2022

This method:

Flux.jl/src/optimise/train.jl

Line 9 in d0a5b77

function update!(x::AbstractArray, x̄)

is never called. It's also not tested.
Only the three-arg method is used.

Do we need this two-arg method of this function here?
@cossio cossio changed the title Is the two-arg update!(x, d) ever called? Two-arg update!(x, d) is never used Feb 4, 2022
@mcabbott mcabbott mentioned this issue Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cossio