Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] No logsumexp in NNlib page #1718

Closed
JinraeKim opened this issue Sep 25, 2021 · 3 comments · Fixed by #1719
Closed

[Documentation] No logsumexp in NNlib page #1718

JinraeKim opened this issue Sep 25, 2021 · 3 comments · Fixed by #1719

Comments

@JinraeKim
Copy link

JinraeKim commented Sep 25, 2021

In NNlib page, I cannot find a documentation of logsumexp, while it's written here.

I think it would be better to expose this function explicitly.

@JinraeKim
Copy link
Author

One more: why is it numerically stable? Can you share any references or small comments?

@DhairyaLGandhi
Copy link
Member

Yes, that would require an addition to https://github.com/FluxML/Flux.jl/blob/master/docs/src/models/nnlib.md

I pushed out a quick PR to add it in.

https://gregorygundersen.com/blog/2020/02/09/log-sum-exp/ seems like a decent explanation of why it's stable.

@JinraeKim
Copy link
Author

@DhairyaLGandhi Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants