Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep links and universal links fail to navigate to the correct screen when the app is already open. #934

Closed
rola-bevol opened this issue Feb 1, 2024 · 1 comment · Fixed by #950
Labels
new New issue request attention

Comments

@rola-bevol
Copy link

Describe the bug
While the app is openend, and if user tried to open a url for the app with route e.g. example.com/post/1 the route will not work and will just open the home page, after debugging found that:

In flutter_modular/lib/src/presenter/navigation/modular_route_information_parser.dart:52
if we stoop
_firstParse = true;
will navigate normally.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

  1. Open an app which support Deeplink and universal link.
  2. Switch to another app, to get app url with route like (example.com/post/1)
  3. click the link, the app will open to home screen without nagigation to post screen.

Expected behavior
The app should navigate to desired post screen.

@rola-bevol rola-bevol added the new New issue request attention label Feb 1, 2024
@danteCarvalho
Copy link

i have the same problem, do you have a workaround or should i just downgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new New issue request attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants