Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-text widget layout value does not respect setting #184

Closed
Steve-Mcl opened this issue Sep 8, 2023 · 2 comments · Fixed by #328
Closed

ui-text widget layout value does not respect setting #184

Steve-Mcl opened this issue Sep 8, 2023 · 2 comments · Fixed by #328
Assignees
@joepavitt
Labels
bug Something isn't working size:S - 2 Sizing estimation point

Comments

@Steve-Mcl
Copy link
Contributor

The layout of ui-text widget seems to have no effect on the render.

chrome_agd8J3YsTW.mp4
@Steve-Mcl Steve-Mcl changed the title Spacing between label and value does not respect setting ui-text widget layout value does not respect setting Sep 8, 2023
@Steve-Mcl Steve-Mcl added size:S - 2 Sizing estimation point bug Something isn't working labels Sep 8, 2023
@colinl
Copy link
Contributor

colinl commented Sep 19, 2023

I think this used to work, at least for some layout options, but I can confirm it is not working for me too with 0.5.0

@joepavitt joepavitt moved this from Backlog to In Progress in Dashboard Backlog Nov 8, 2023
@joepavitt joepavitt self-assigned this Nov 8, 2023
@joepavitt
Copy link
Collaborator

Turns out this was broken in #169 with the removal of:
:class="'nrdb-ui-text--' + props.layout" - adding it back in with a new PR

@joepavitt joepavitt mentioned this issue Nov 8, 2023
Merged
1 task
@github-project-automation github-project-automation bot moved this from In Progress to Done in Dashboard Backlog Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joepavitt joepavitt

Labels
bug Something isn't working size:S - 2 Sizing estimation point
Projects
Dashboard Backlog
Status: Done
Milestone
No milestone
3 participants
@colinl @Steve-Mcl @joepavitt