Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typedinput for buttons in ui-table #1188

Closed
bartbutenaers opened this issue Aug 9, 2024 · 5 comments · Fixed by #1349
Closed

Typedinput for buttons in ui-table #1188

bartbutenaers opened this issue Aug 9, 2024 · 5 comments · Fixed by #1349
Assignees
Labels
size:S - 2 Sizing estimation point

Comments

@bartbutenaers
Copy link
Contributor

As discussed here a typedinput for the buttons in a ii-table would be more user friendly.

I will take care of this as soon as I have time.

@joepavitt joepavitt moved this from Backlog to Up Next in Dashboard Backlog Sep 18, 2024
@joepavitt joepavitt added the size:S - 2 Sizing estimation point label Sep 18, 2024
@joepavitt
Copy link
Collaborator

Going to give this to @Steve-Mcl as he has a little wiggle room at the moment

@Steve-Mcl
Copy link
Contributor

Hey @bartbutenaers I have read the linked issue several times. I may just be tired but I am not certain what the task is?

Any chance you could add some detail to this issue pls?

An annotated screenshot describing your expectation would go a long way to help.

Ta.

@Steve-Mcl
Copy link
Contributor

@joepavitt I am not 100% clear on the requirement of this. Could you or @bartbutenaers clarify please?

@joepavitt
Copy link
Collaborator

Currently, buttons will render their label based on the "Key" value. However, that means you have to manually inject a value into your row of data, e.g. if you want a button saying "Delete":

{
    "delete": "Delete Me"
}

setting the "Key" value to delete, would then render "Delete Me" in the button. Ideally, we'd have the option to just render a static string for all buttons, so a TypedInput on the Key field I think is the solution here?

We may need to change the "Key" label in the config to "Value", then the TypedInput would have Key and String options?

@bartbutenaers
Copy link
Contributor Author

Hi @Steve-Mcl,
Sorry for the delay!
Well I understand your confusion. I also had now to reread the discussion a couple of times to load it all back into my brain. But I see that you have meanwhile created a PR to implement Joe's feedback.
Thanks for that!!

@github-project-automation github-project-automation bot moved this from Up Next to Done in Dashboard Backlog Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S - 2 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants