Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose recipients validation logic #833

Closed
tomholub opened this issue Oct 28, 2021 · 3 comments
Closed

compose recipients validation logic #833

tomholub opened this issue Oct 28, 2021 · 3 comments
Assignees
Milestone

Comments

@tomholub
Copy link
Collaborator

I'm not too sure about this - the validation happens asynchronously as a task. Would that be of any use? By the time it figures out it's wrong, this method may already finish.

Originally posted by @tomholub in #821 (comment)

@sosnovsky
Copy link
Collaborator

It's just for UI, because when recipient is selected then user won't be able to see if it's highlighted with red or orange color. Evaluation result isn't used for determining valid recipients.

@tomholub
Copy link
Collaborator Author

What would happen if these two lines were removed from ComposeViewController.sendMessage?

@sosnovsky
Copy link
Collaborator

Here are example videos - to reproduce you just need to add some invalid recipient (expired or revoked), then tap on it to select and try to send email.

Here how it works with these 2 lines (recipient highlighted after showing error modal):
https://user-images.githubusercontent.com/1062093/139436192-78a41417-7f83-4e5a-9437-318522e9dbe0.mp4

And without (recipient stays gray, because of selected state)
https://user-images.githubusercontent.com/1062093/139436265-4c61107a-e55d-4e99-b814-925167b6ea00.mp4

@tomholub tomholub changed the title message send recipients validation wrongly asynchronous? compose recipients validation logic Oct 29, 2021
@tomholub tomholub assigned tomholub and unassigned sosnovsky Oct 29, 2021
@tomholub tomholub closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants