Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2367 Show move to inbox button for all cases when it's not inbox #2380

Merged

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Sep 29, 2023

This PR shows move to inbox button for all cases when it's not inbox

close #2367 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review September 29, 2023 15:41
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I noticed a small issue:

  • compose and send new email
  • go to Sent folder (or All Mail), open sent message
  • toolbar shows move to inbox button, but should show move to archive button (as Gmail app does)

@ioanmo226
Copy link
Collaborator Author

I believe Gmail's logic for handling sent emails is flawed.
Archiving Sent emails/threads doesn't seem to have a purpose.(it actually does nothing)

Instead, offering a 'Move to Inbox' option for sent items would make more sense to me

@sosnovsky
Copy link
Collaborator

Yeah, agree - I tried to archive sent message in Gmail app and nothing changed. So let's leave it as is.

But I noticed another issue:

  • compose and send new email
  • go to Sent screen, open sent message
  • tap move to inbox
  • app redirected back to Sent screen
  • opened sent message is removed from messages list - but it should stay there, as it's not removed from sent email, it's just added to inbox

@ioanmo226
Copy link
Collaborator Author

Yep!. Nice catch. let me fix it

@ioanmo226 ioanmo226 requested a review from sosnovsky October 2, 2023 09:54
@ioanmo226 ioanmo226 requested a review from sosnovsky October 2, 2023 12:10
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now 👍

@sosnovsky sosnovsky enabled auto-merge (squash) October 2, 2023 12:23
@sosnovsky sosnovsky merged commit 8347176 into master Oct 2, 2023
5 checks passed
@sosnovsky sosnovsky deleted the 2367-mail-in-all-mail-archived-cannot-be-moved-back-to-inbox branch October 2, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mail in All Mail (archived) cannot be moved back to inbox
2 participants