-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2367 Show move to inbox
button for all cases when it's not inbox
#2380
#2367 Show move to inbox
button for all cases when it's not inbox
#2380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I noticed a small issue:
- compose and send new email
- go to Sent folder (or All Mail), open sent message
- toolbar shows
move to inbox
button, but should showmove to archive
button (as Gmail app does)
I believe Gmail's logic for handling sent emails is flawed. Instead, offering a 'Move to Inbox' option for sent items would make more sense to me |
Yeah, agree - I tried to archive sent message in Gmail app and nothing changed. So let's leave it as is. But I noticed another issue:
|
Yep!. Nice catch. let me fix it |
FlowCrypt/Controllers/Inbox/InboxViewController+TableView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now 👍
This PR shows
move to inbox
button for all cases when it's not inboxclose #2367 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):