Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop adding then replacing port 8001 in mock builds #4953

Closed
tomholub opened this issue Feb 13, 2023 · 3 comments · Fixed by #5887
Closed

stop adding then replacing port 8001 in mock builds #4953

tomholub opened this issue Feb 13, 2023 · 3 comments · Fixed by #5887
Assignees
@ioanmo226
Labels
actionable
Milestone
8.5.9

Comments

@tomholub
Copy link
Collaborator

tomholub commented Feb 13, 2023 •
edited
Loading

I suppose it could.. we would still need to do two rounds of replacing? The step that normally replaces [BUILD_REPLACEABLE_....] and currently puts the :8001 would still need to insert some more maybe [TEST_REPLACEABLE_MOCK_PORT] and then that would be replaced here.

It's true that as things are now, there is no meaning to the :8001 in particular. So that should not be put it, to not be confusing. So [TEST_REPLACEABLE_MOCK_PORT] or similar would be a better choice here.

Originally posted by @tomholub in #4928 (comment)
@tomholub
Copy link
Collaborator Author

image

@tomholub tomholub added this to the 8.4.5 milestone Feb 13, 2023
@rrrooommmaaa
Copy link
Contributor

I suggest to also implement removing the lines that have this token, e.g. the line
email = email.replace(/\:[TEST_REPLACEABLE_MOCK_PORT]$/, '');
would ideally disappear from the production build.

@tomholub
Copy link
Collaborator Author

ok. that's a separate issue, let's file it separately. agree with it though in principle. need to check exactly which things does such change touch

@sosnovsky sosnovsky modified the milestones: 8.5.2, 8.5.3 Oct 25, 2023
@sosnovsky sosnovsky modified the milestones: 8.5.4, 8.5.5 Mar 1, 2024
@sosnovsky sosnovsky modified the milestones: 8.5.5, 8.5.6 May 13, 2024
@sosnovsky sosnovsky modified the milestones: 8.5.6, First priority May 23, 2024
@sosnovsky sosnovsky modified the milestones: First priority, 8.5.9 Dec 18, 2024
@ioanmo226 ioanmo226 mentioned this issue Dec 24, 2024
Merged
5 tasks
sosnovsky pushed a commit that referenced this issue Jan 7, 2025
@ioanmo226
#4953 Use test replaceable port (#5887)
7adc496 
* feat: use test replaceable port

* fix: pr reviews

* fix: unit test

* fix: ui test

* fix: writeFile

* fix: ppr reviews

* fix: remove port check

* Revert "fix: remove port check"

This reverts commit d7a2022.

* fix: mock port variable

* Revert "fix: mock port variable"

This reverts commit 017ac27.

* fix: pr reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ioanmo226 ioanmo226

Labels
actionable
Projects
None yet
Milestone
8.5.9
Development

Successfully merging a pull request may close this issue.

#4953 Use test replaceable port FlowCrypt/flowcrypt-browser
4 participants
@sosnovsky @tomholub @rrrooommmaaa @ioanmo226