Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User suggestion] Default public key inclusion preference #5859

Open
martgil opened this issue Nov 8, 2024 · 2 comments
Open

[User suggestion] Default public key inclusion preference #5859

martgil opened this issue Nov 8, 2024 · 2 comments

Comments

@martgil
Copy link
Collaborator

martgil commented Nov 8, 2024

Description: Public key inclusion can happen automatically in case receiver doesn't have public key of the sender.

for (const recipient of foreignRecipients) {
// new message, and my key is not uploaded where the recipient would look for it
if (!(await this.view.recipientsModule.doesRecipientHaveMyPubkey(recipient))) {
// they do need pubkey
// To improve situation reported in #5609, a notification message about the automatic public key inclusion is displayed
this.setAttachPreference(true);
this.view.S.cached('warning_no_pubkey_on_attester').css('display', 'block');
return;
}
}

User doesn't seem to prefer this, and suggested if its possible to for us to add a default public key inclusion preference.

Discussion regarding the reporting user: https://mail.google.com/mail/u/[email protected]/#inbox/FMfcgzGxRfFtxbXfhgjhGpbhLrmmxpTl

@martgil martgil added this to the discussion milestone Nov 8, 2024
@martgil
Copy link
Collaborator Author

martgil commented Nov 8, 2024

Hi @sosnovsky - Good afternoon. I just wanted to inform you about a user-suggested feature and ask if there's any chance this could be included in our development roadmap.

@sosnovsky
Copy link
Collaborator

Hi @martgil, as I recall, this is the first request for such functionality—usually, users are fine with the automatic key attachment. Let's add it to our backlog with low priority.

@martgil martgil modified the milestones: discussion, Third priority Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants