Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5805 Fix unstable tests in semaphoreci #5843

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

#5805 Fix unstable tests in semaphoreci #5843

wants to merge 1 commit into from

Conversation

ioanmo226
Copy link
Collaborator

This PR fixed unstable tests in semaphoreci

close #5805 // if this PR closes an issue

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky
Copy link
Collaborator

@ioanmo226 I've also noticed that sometimes unit tests time out, leading to their failure:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky Awaiting requested review from sosnovsky sosnovsky will be requested when the pull request is marked ready for review sosnovsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable tests in Semaphoreci
2 participants
@ioanmo226 @sosnovsky