#5664 Pull email's received time directly on Gmail #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sosnovsky, I hope you're doing well. I'd like to check if you have any preferences regarding the date and time format, or if the one proposed in this PR is sufficient? |
sosnovsky
reviewed
Apr 15, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sosnovsky
reviewed
Apr 26, 2024
|
Hi @sosnovsky I have re-run the test but the failing one is not related to my PR. This should be good to go. |
sosnovsky
reviewed
Apr 26, 2024
…evied-email-time-from-gmail
|
Hi @sosnovsky does this look good to you? I also plan to share a build coming from this PR to double-check if the user would get his desired date and time when print-previewing email -- it should work fine. |
sosnovsky
reviewed
May 8, 2024
sosnovsky
reviewed
May 10, 2024
…evied-email-time-from-gmail
sosnovsky
reviewed
May 13, 2024
…evied-email-time-from-gmail
sosnovsky
approved these changes
May 14, 2024
Thanks, @sosnovsky. I've informed him, but still haven't heard their feedback. I'll update you as soon as I have it. |
|
@martgil I merged this PR, to include it in the upcoming release. |
ioanmo226
pushed a commit
that referenced
this pull request
May 27, 2024
* Pull email's received time directly on Gmail * update common.ts's fromDate function * fix failing test * revert changes * revert changes on common.ts * Use Gmail's received date cautiously, with the header date as a fallback * add proper date validity checking * revert changes * revert changes * Ensure the retrieval of the received date on Gmail is fail-safe * detect gmail timezone and use simple yyyy-dd-mm format used in toISOString() * add comments * code simplification * Unset user's date locale * use UTC Timezones * Fix correct time * revert changes * determine date/time based on Gmail settings * revert changes * update tests * apply simplification * update test * fix test * update test * removed unnecessary tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to pull the exact time an email was received from Gmail. This also resolves issues with accurately retrieving the time, whether it's in a 12 or 24-hour format, since it's already provided within the pulled data from Gmail.
close #5664
Screenshots:
Opening the same email using different time format
12 hour format:
24 hour format:
To change time format in Gmail:
1.) Go to Gmail Settings -> See all settings.
2.) Change language from 'English US' to 'English UK'.
3.) Save and open the desired email.
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):