Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump squire-rte from 1.11.3 to 2.2.2 #5442

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 4, 2023

Bumps squire-rte from 1.11.3 to 2.2.2.

close #5443

Changelog

Sourced from squire-rte's changelog.

[2.2.2] - 2023-10-04

Fixed

  • Added a workaround for a bug in Chrome that resulted in text in the editor not being rendered in certain circumstances.

[2.2.1] - 2023-10-03

Fixed

  • Fixed a bug in the exported extractRangeToClipboard fn if used in a certain configuration.

[2.2.0] - 2023-10-02

Added

  • The Squire config now has support for a toPlainText function, that takes an HTML string and should return the plain text version of that content to be added to the clipboard when cutting/copying.

Changed

  • The default conversion of the HTML to plain text when cutting/copying now uses the same algorithm as the getSelectedText method.

[2.1.1] - 2023-09-27

Fixed

  • If you changed inline formatting in Chrome and then hit space, the formatting would be lost. This is now fixed.

[2.1.0] - 2023-09-19

Added

  • If you start a new line with "*" then a space, Squire will now automatically set the format to an unordered list.
  • If you start a new line with "1." then a space, Squire will now automatically set the format to an ordered list.

[2.0.3] - 2023-04-20

Fixed

  • Fixed an error being thrown when you typed a URL in the middle of a text node. fastmail/Squire#430

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [squire-rte](https://github.com/neilj/Squire) from 1.11.3 to 2.2.2.
- [Changelog](https://github.com/fastmail/Squire/blob/master/CHANGELOG.md)
- [Commits](https://github.com/neilj/Squire/commits)

---
updated-dependencies:
- dependency-name: squire-rte
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from sosnovsky as a code owner October 4, 2023 06:42
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 4, 2023
@FlowCryptRobot FlowCryptRobot enabled auto-merge (squash) October 4, 2023 06:42
FlowCryptRobot
FlowCryptRobot previously approved these changes Oct 4, 2023
@ioanmo226
Copy link
Collaborator

ioanmo226 commented Oct 6, 2023

@sosnovsky, the current version of squire-rte has a trio of bugs. Should I go ahead and push fixes to the upstream squire-rte repository, or wait for them to handle it?

What do you reckon?

@sosnovsky
Copy link
Collaborator

I think it'll be faster if you can fix these things and submit PR to squire-rte repo.
Hopefully they'll approve it this time :)

@ioanmo226
Copy link
Collaborator

Heads up, while working on the Squire-Rte issues, I found that the second issue isn't relevant. The setKeyHandler event didn't function as expected because v1.0 treated ctrlKey as ctrl-, while v2.0 treats it as Ctrl- (note the capitalized first letter).

After I changed below line to Ctrl-, Meta-, it works fine.

https://github.com/ioanmo226/Squire/blob/8304fd3e0485c0a976e0907ba9d3030ffaac5bcb/source/keyboard/KeyHandlers.ts#L70

@ioanmo226
Copy link
Collaborator

ioanmo226 commented Oct 9, 2023

Submitted PR at fastmail/Squire#443

@sosnovsky
Copy link
Collaborator

Well done, let's wait for their review

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 15, 2023

A newer version of squire-rte exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@FlowCryptRobot FlowCryptRobot merged commit d8b4dc6 into master Oct 25, 2023
8 checks passed
@FlowCryptRobot FlowCryptRobot deleted the dependabot/npm_and_yarn/squire-rte-2.2.2 branch October 25, 2023 05:46
ioanmo226 added a commit that referenced this pull request Oct 25, 2023
@ioanmo226
Copy link
Collaborator

@sosnovsky Oops. I approved this PR by mistake. (Already finished though)
Please review and leave comments if you find something wrong.
I'll make follow-up PR after that

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, haven't noticed any issues after upgrade 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update squire-rte to v2
3 participants