-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump squire-rte from 1.11.3 to 2.2.2 #5442
build(deps): bump squire-rte from 1.11.3 to 2.2.2 #5442
Conversation
Bumps [squire-rte](https://github.com/neilj/Squire) from 1.11.3 to 2.2.2. - [Changelog](https://github.com/fastmail/Squire/blob/master/CHANGELOG.md) - [Commits](https://github.com/neilj/Squire/commits) --- updated-dependencies: - dependency-name: squire-rte dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
@sosnovsky, the current version of squire-rte has a trio of bugs. Should I go ahead and push fixes to the upstream squire-rte repository, or wait for them to handle it?
What do you reckon? |
I think it'll be faster if you can fix these things and submit PR to squire-rte repo. |
Heads up, while working on the Squire-Rte issues, I found that the second issue isn't relevant. The After I changed below line to flowcrypt-browser/extension/chrome/elements/compose-modules/compose-input-module.ts Line 187 in 66a44c2
|
Submitted PR at fastmail/Squire#443 |
Well done, let's wait for their review |
A newer version of squire-rte exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This reverts commit d8b4dc6.
@sosnovsky Oops. I approved this PR by mistake. (Already finished though) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, haven't noticed any issues after upgrade 👍
Bumps squire-rte from 1.11.3 to 2.2.2.
close #5443
Changelog
Sourced from squire-rte's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)