Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug html attachments on Semaphore not contain screenshots #5396

Closed
sosnovsky opened this issue Sep 4, 2023 · 1 comment · Fixed by #5592
Closed

Debug html attachments on Semaphore not contain screenshots #5396

sosnovsky opened this issue Sep 4, 2023 · 1 comment · Fixed by #5592
Assignees
@tomholub
Labels
actionable
Milestone
First priority

Comments

@sosnovsky
Copy link
Collaborator

sosnovsky commented Sep 4, 2023 •
edited
Loading

Previously debug html attachments had screenshots and information about reason for test failure, but currently they have only mock API logs (example - https://flowcrypt.semaphoreci.com/jobs/0be03fb0-c584-4943-b6d5-4164e2a94ce3/artifacts)

Issue probably appeared after updating to Puppeteer 21.0.0, as testFailSingleAttemptDebugHtml fails with error Error: Requesting main frame too early!. It works well in Puppeteer 20.9.0
@sosnovsky sosnovsky added this to the 8.5.1 milestone Sep 4, 2023
This was referenced Sep 5, 2023
Closed
Merged
@sosnovsky sosnovsky modified the milestones: 8.5.1, 8.5.2 Sep 29, 2023
@sosnovsky sosnovsky modified the milestones: 8.5.2, 8.5.3 Oct 25, 2023
@sosnovsky sosnovsky modified the milestones: 8.5.4, 8.5.5 Mar 1, 2024
@sosnovsky sosnovsky modified the milestones: 8.5.5, 8.5.6 May 13, 2024
@sosnovsky sosnovsky modified the milestones: 8.5.6, 8.5.7, First priority May 23, 2024
@tomholub tomholub self-assigned this May 29, 2024
@tomholub
Copy link
Collaborator

Related issue, the debug files are not getting uploaded to Semaphore at all. I'll try to address that in #5748

@tomholub tomholub mentioned this issue May 29, 2024
Merged
5 tasks
@sosnovsky sosnovsky mentioned this issue Jun 26, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomholub tomholub

Labels
actionable
Projects
None yet
Milestone
First priority
Development

Successfully merging a pull request may close this issue.

#5498 Upgrade to puppeteer v22 FlowCrypt/flowcrypt-browser
2 participants
@sosnovsky @tomholub