Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

could key be sent to background page binary / unarmored? #4904

Closed
tomholub opened this issue Jan 24, 2023 · 1 comment · Fixed by #4725
Closed

could key be sent to background page binary / unarmored? #4904

tomholub opened this issue Jan 24, 2023 · 1 comment · Fixed by #4725
Assignees
@rrrooommmaaa
Labels
actionable
Milestone
8.4.3: Use shared...

Comments

@tomholub
Copy link
Collaborator

Would it be faster to send the key in binary representation (unarmored openpgp key)? Armoring/de-armoring is oddly expensive, about 10ms per key. Could be separate PR.

Originally posted by @tomholub in #4725 (comment)
@tomholub
Copy link
Collaborator Author

image

@tomholub tomholub added this to the 8.4.4 milestone Jan 24, 2023
@tomholub tomholub mentioned this issue Jan 24, 2023
Merged
5 tasks
@rrrooommmaaa rrrooommmaaa self-assigned this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrrooommmaaa rrrooommmaaa

Labels
actionable
Projects
None yet
Milestone
8.4.3: Use shared-tenant-fes instead ...
Development

Successfully merging a pull request may close this issue.

Switch to OpenPGP v5 FlowCrypt/flowcrypt-browser
2 participants
@tomholub @rrrooommmaaa