Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved parsing InternetAddress #2820

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Improved parsing InternetAddress #2820

merged 1 commit into from
Jul 31, 2024

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Jul 30, 2024 •
edited by sosnovsky
Loading

This PR Improved parsing InternetAddress

close #2819

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review July 31, 2024 04:56
@DenBond7 DenBond7 requested a review from sosnovsky as a code owner July 31, 2024 04:56
sosnovsky
sosnovsky approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sosnovsky sosnovsky merged commit 705ab4c into master Jul 31, 2024
8 checks passed
@sosnovsky sosnovsky deleted the issue_2819_fix_user_id_issue branch July 31, 2024 11:07
@DenBond7 DenBond7 mentioned this pull request Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve parsing InternetAddress
2 participants
@DenBond7 @sosnovsky