Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKM keys refresh: allow removing keys, except when revoked + improve revoked handing #1768

Closed
tomholub opened this issue Apr 29, 2022 · 9 comments · Fixed by #1863
Closed
Assignees
Labels

Comments

@tomholub
Copy link
Collaborator

tomholub commented Apr 29, 2022

same as FlowCrypt/flowcrypt-ios#1559

@tomholub tomholub added this to the 1.3.5: Revoked keys milestone Apr 29, 2022
@DenBond7 DenBond7 self-assigned this Jun 14, 2022
@DenBond7
Copy link
Collaborator

DenBond7 commented Jun 22, 2022

Test the following cases:

  • disallow update revoked keys
  • disallow delete revoked keys
  • delete not matching keys

@IvanPizhenko
Copy link
Contributor

IvanPizhenko commented Jun 22, 2022

This one sounds strange - "don't delete at least one key. To prevent unexpected issues we should be sure that at least one private key is existing in the app". What if customer just installed the app and doesn't have any keys yet?

@DenBond7
Copy link
Collaborator

That's not about a fresh install. It relates to updating existing keys via EKM

DenBond7 added a commit that referenced this issue Jun 22, 2022
@tomholub
Copy link
Collaborator Author

Actually, if EKM wants to delete all keys, you should be deleting all keys.

What would currently happen to the app if you did that? Many things would not function (sending, opening email) but is it otherwise functional?

@DenBond7
Copy link
Collaborator

The problem is we don't support it. A user should have at least one private key to prevent unexpected behavior. I really don't know what will happen and where in that case. In that case need to be ready for issues over the whole app. Today we have a big app... and too many places where we can have a bug.

@DenBond7
Copy link
Collaborator

By the way, what is a reason to delete all user's keys? And leave a user without keys.

@tomholub
Copy link
Collaborator Author

Maybe they left the company, or maybe the admin deleted their keys with the intention to give them new ones.

You could log the account out when this happens. Then at least you follow what EKM says - delete keys.

@tomholub
Copy link
Collaborator Author

You could log the account out when this happens. Then at least you follow what EKM says - delete keys.

Later we look into it as a separate issue to see if we could support situation of not having any keys anymore

@DenBond7
Copy link
Collaborator

Later we look into it as a separate issue to see if we could support situation of not having any keys anymore

I think it will be interesting over all platforms

DenBond7 added a commit that referenced this issue Jun 23, 2022
DenBond7 added a commit that referenced this issue Jun 23, 2022
* EKM keys refresh: allow removing keys, except when revoked + improve revoked handing.| #1768

* Added some tests.| #1768

* Added changes to RefreshPrivateKeysFromEkmViewModel.| #1768

* Refactored code.| #1768

* Temporary disabled some Junit tests.| #1768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants