Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: application does not support the current operation on symbolic links #3011

Open
2 tasks done
ashish0kumar opened this issue Oct 5, 2024 · 12 comments · May be fixed by #3177
Open
2 tasks done

BUG: application does not support the current operation on symbolic links #3011

ashish0kumar opened this issue Oct 5, 2024 · 12 comments · May be fixed by #3177
Labels
bug Something isn't working

Comments

@ashish0kumar
Copy link

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

Since, I symlinked the config of flow launcher to my dotfiles flow launcher config. This error is showing on startup:
System.IO.IOException: This application does not support the current operation on symbolic links.

To Reproduce

  1. Symlink the flow launcher config
  2. Run flow launcher at startup

Screenshots

No response

Flow Launcher Version

1.19.2

Windows Build Number

10.0.22631.4169

Error Log

log file

@ashish0kumar ashish0kumar added the bug Something isn't working label Oct 5, 2024
@taooceros
Copy link
Member

Yeah to provide atomicity of the file operation we do not support symbolic link to prevent potential data corruption.

@taooceros
Copy link
Member

If more request to this we can consider switching to an embedded database rather than plain text.

@bropines
Copy link

bropines commented Oct 8, 2024

My programs plugin recursively tried to count symlinks in the start menu, which is why the log weighed 15 GB
explorer_j9A7w0Dil0

@taooceros
Copy link
Member

My programs plugin recursively tried to count symlinks in the start menu, which is why the log weighed 15 GB explorer_j9A7w0Dil0

huh that's a different issue. Could you fire another one? Also could you show some snippet inside the very large log that count symlink?

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 60 days.\n\nAlternatively this issue can be kept open by adding one of the following labels:\nkeep-fresh

@github-actions github-actions bot added the Stale label Dec 29, 2024
Copy link

github-actions bot commented Jan 6, 2025

This issue was closed because it has been stale for 7 days with no activity. If you feel this issue still needs attention please feel free to reopen.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2025
@helmesjo
Copy link

helmesjo commented Jan 9, 2025

@taooceros Wouldn't this be trivial to solve by simply first resolving the path, then call ReplaceFile()?

@taooceros taooceros reopened this Jan 9, 2025
@taooceros
Copy link
Member

@taooceros Wouldn't this be trivial to solve by simply first resolving the path, then call ReplaceFile()?

I guess it makes sense? I am not quite familiar with symlink.

Are you proposing we resolve the final path and then replace the final file instead of the symlink?

@taooceros taooceros linked a pull request Jan 9, 2025 that will close this issue
@helmesjo
Copy link

helmesjo commented Jan 9, 2025

Are you proposing we resolve the final path and then replace the final file instead of the symlink?

Correct. If the problem is a path that includes one or more symlinks being passed to one of the functions, it should work to just first resolve it (that is, the resolved path no longer contains any symlink(s), it'll just be a simple absolute path) and then invoke the function.
I don't use C# but just intuitively I would guess that should work.

@bropines
Copy link

My programs plugin recursively tried to count symlinks in the start menu, which is why the log weighed 15 GB explorer_j9A7w0Dil0

huh that's a different issue. Could you fire another one? Also could you show some snippet inside the very large log that count symlink?

Ouch.... I didn't see the notification. I can try to repeat that bug. It's done in a couple of minutes.

@taooceros
Copy link
Member

@ashish0kumar
Copy link
Author

@taooceros I tested the build, and I'm now able to symlink files without any issues. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants