Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon should change when the folder of a note changes (Inherit icons) #178

Closed
AB-boi opened this issue May 7, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@AB-boi
Copy link

AB-boi commented May 7, 2023

(I use Obsidian on my iPad.)
I'm grateful for the Icon Folder plugin.

The Background

Each of my folders has a different icon with inherit icons enabled. This way I can also use an icon for identifying my note type as it shows up nicely in the edge of stacked tabs like this -
2A9B2ACB-812E-4579-BED0-5826A5A0EEF4

The Problem -

  1. I create a note within a folder (in this case, 'Literature') and it inherits its icon, like this -
    80A9B737-BDF5-4399-9800-49807B5E2697

Which is good, but
2) If it gets moved to a new folder with a different inheritable icon (in this case, 'Concepts'), it now doesn't take up the new icon in the sidebar (but this new icon still shows up correctly in the edge of a stack tab), like this- (Ignore 'The Book Thief' tab)
17A88B91-C65A-457B-A489-E118968CC58D

My Request/Suggestion -

  1. Please make it such that a note (without a manually assigned icon) takes up an icon according to the folder that contains it and even updates it upon moving the note into different folders.

  2. Also some people might want a note to retain the icon assigned by them manually. In which case give precedence to a manually added icon over an inherited icon (It already does this, so maybe keep it that way ?)

Thank you for your time @FlorianWoelki .

@FlorianWoelki FlorianWoelki added the enhancement New feature or request label May 8, 2023
@FlorianWoelki FlorianWoelki self-assigned this May 8, 2023
@FlorianWoelki FlorianWoelki added bug Something isn't working and removed enhancement New feature or request labels May 8, 2023
@FlorianWoelki
Copy link
Owner

Thank you for your suggestion. This is actually a bug and I'll fix that soon.

Regarding the second point: the icon you manually set should be always prioritized over the inherited icons.

@AB-boi AB-boi closed this as completed May 8, 2023
@AB-boi AB-boi reopened this May 11, 2023
@AB-boi
Copy link
Author

AB-boi commented May 31, 2023

@FlorianWoelki
Hi !
Sorry to ping you like this but I am new to Github and I closed the issue by mistake. I have reopened it but I don't know if it's on the upcoming roadmap for fixes.

@FlorianWoelki
Copy link
Owner

This is now fixed in v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants