New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreach should abort on error and return #50

Closed

Flipez opened this issue Jan 16, 2022 · 0 comments · Fixed by #62

Labels

bug

Owner

Flipez commented Jan 16, 2022 •

edited

Loading

foreach should interrupt on return or error, currently the abort handling does exlcude error in the second statement.

rocket-lang/evaluator/foreach.go

Line 45 in b655395

    
           if rt != nil && !isError(rt) && (rt.Type() == object.RETURN_VALUE_OBJ || rt.Type() == object.ERROR_OBJ) {

should probably:

 if rt != nil && (rt.Type() == object.RETURN_VALUE_OBJ || rt.Type() == object.ERROR_OBJ) {

Flipez added the bug label

Flipez mentioned this issue

Foreach error abort #62

Merged

Flipez closed this as completed in #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment