Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional properties #29

Closed
Flaxoos opened this issue Apr 18, 2024 · 4 comments
Closed

Support for additional properties #29

Flaxoos opened this issue Apr 18, 2024 · 4 comments
Labels
awaiting fix confirmation Fixed, needs to be validated by issue poster enhancement New feature or request

Comments

@Flaxoos
Copy link
Owner

Flaxoos commented Apr 18, 2024

The plugin should also allow configuration of additional properties, such as SASL, SSL, and Security.

see #26

@Flaxoos Flaxoos added the enhancement New feature or request label Apr 18, 2024
@diegopatinor
Copy link
Contributor

Hi @Flaxoos, is this not developed yet?

@Flaxoos
Copy link
Owner Author

Flaxoos commented Jul 5, 2024

Hi @diegopatinor unfortunately not yet, im busy with other tasks on another project of mine. Would you like to take this on? It's probably pretty straightforward and just a matter of extending the configuration classes

@Flaxoos
Copy link
Owner Author

Flaxoos commented Nov 11, 2024

@diegopatinor this has been addressed in v2.1.0 https://github.com/Flaxoos/extra-ktor-plugins/releases/tag/v2.1.0, you can now do for example:

 install(Kafka) {
                   ...
                    consumer {
                            additional {
                                ANY_PROPERTY_STRING("some value")
                            }
                    }
                    commonSsl {
                        broker {
                            protocol = "TLSv1.2"
                            endpointIdentificationAlgorithm = ""
                            trustStore {
                                location = "path_to_file"
                                password ="password"
                            }
                            keyStore {
                                location = "path_to_file"
                                password ="password"
                            }
                            keyPassword = PASSWORD
                        }
                        schemaRegistry {
                            protocol = "TLSv1.2"
                            endpointIdentificationAlgorithm = ""
                            trustStore {
                                location = "path_to_file"
                                password ="password"
                            }
                            keyStore {
                                location = "path_to_file"
                                password ="password"
                            }
                            keyPassword = PASSWORD
                        }
                    }
              }

@Flaxoos Flaxoos added the awaiting fix confirmation Fixed, needs to be validated by issue poster label Nov 11, 2024
@Flaxoos
Copy link
Owner Author

Flaxoos commented Nov 12, 2024

Closing as fixed

@Flaxoos Flaxoos closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting fix confirmation Fixed, needs to be validated by issue poster enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants