Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlaceholderAPI Implementation #48

Open
1 of 6 tasks
FlashyReese opened this issue Jan 14, 2023 · 2 comments
Open
1 of 6 tasks

PlaceholderAPI Implementation #48

FlashyReese opened this issue Jan 14, 2023 · 2 comments
Assignees
@FlashyReese
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@FlashyReese
Copy link
Owner

Originally brought up in #46.

Targeted branch: https://github.com/FlashyReese/CommandAliases/tree/placeholders-api-impl

  • Replace in-house function processor with Placeholder API to reduce maintenance and bug-fixing efforts. Keep the deprecated function processor for a few releases to allow users to adjust to the change.
  • Transition all functions to use Placeholder API
    • Implement dynamic passing of functions to Placeholder API for servers
    • Implement dynamic passing of functions to Placeholder API for clients
      • Wait for Placeholder API to support FabricClientCommandSource as a context
  • Update documentation on the wiki to reflect the changes made
@FlashyReese FlashyReese added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 14, 2023
@FlashyReese FlashyReese self-assigned this Jan 14, 2023
@FlashyReese FlashyReese pinned this issue Jan 25, 2023
@FlashyReese
Copy link
Owner Author

This will only be implemented for 1.19.3 and above. Unless someone is willing to backport and maintain older branches.

@tanyan-tanyan
Copy link

How come you're not implementing this for 1.19.2? (Pls be gentle I don't know much about this stuff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlashyReese FlashyReese

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FlashyReese @tanyan-tanyan