Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add base pages for flank layers #1735

Merged
merged 16 commits into from
Mar 30, 2021
Merged

docs: Add base pages for flank layers #1735

merged 16 commits into from
Mar 30, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Mar 25, 2021 •
edited
Loading

Fixes #1509

This pull request adds documentation pages for the flank layers:

Checklist

  • Update mkdocs.yml

@jan-goral jan-goral self-assigned this Mar 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added Documentation Pull request which touches documentation Tech Debt labels Mar 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2021 •
edited
Loading

Timestamp: 2021-03-29 15:48:29
Buildscan url for ubuntu-workflow run 698390645

@jan-goral
Copy link
Contributor Author

I have to figure out how to serve markdown files for mkdocs, from outside of docs directory. I cannot find it in documentation. Seems to mkdocs forces to use only the docs directory which is a ridiculous design decision. I have to make sure.

Sloox
Sloox suggested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes :)

test_runner/src/main/kotlin/ftl/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/data/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/domain/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/domain/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/domain/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/domain/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/domain/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/domain/README.md Outdated Show resolved Hide resolved
test_runner/src/main/kotlin/ftl/domain/README.md Outdated Show resolved Hide resolved
@jan-goral jan-goral marked this pull request as ready for review March 29, 2021 11:37
jan-goral and others added 16 commits March 29, 2021 15:42
@jan-goral
Add README.md files for flank layers
4730ab0
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/README.md
63bf7ac 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/README.md
f699d84 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/data/README.md
cf2066c 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
8d88105 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
f9cc9ca 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
b99afd0 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
a206939 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
63fee43 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
d4adaf2 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
5e41331 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral
Update mkdocs.yml
172bc4e
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
50729ad 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
7abdc22 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
9cbe134 
Co-authored-by: Michael Wright <[email protected]>
@jan-goral @Sloox
Update test_runner/src/main/kotlin/ftl/domain/README.md
3911bfa 
Co-authored-by: Michael Wright <[email protected]>
@bootstraponline bootstraponline force-pushed the 1509_add_readme_for_layers branch from 2f61d1a to 3911bfa Compare March 29, 2021 15:42
@mergify mergify bot merged commit 238e379 into master Mar 30, 2021
@mergify mergify bot deleted the 1509_add_readme_for_layers branch March 30, 2021 07:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

@zuziaka zuziaka Awaiting requested review from zuziaka

Assignees

@jan-goral jan-goral

Labels
Documentation Pull request which touches documentation Tech Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design table of contents structure
4 participants
@jan-goral @Sloox @pawelpasterz @adamfilipow92