Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and make a SavedMatrix immutable #883

Closed
jan-goral opened this issue Jul 10, 2020 · 1 comment · Fixed by #1028
Closed

Refactor and make a SavedMatrix immutable #883

jan-goral opened this issue Jul 10, 2020 · 1 comment · Fixed by #1028

Comments

@jan-goral
Copy link
Contributor

Author the user story for this feature

As a developer, I want to have SavedMatrix class immutable like a rest of Flank so I can easier understand and operate on flank implementation.

Is your feature request related to a problem? Please describe.
This is last unfinished part of #718. The SavedMatrix is written in object oriented style. Most of flank object oriented code was already rewritten to functional style, so SavedMatrix shouldn't be exception.

Definition of done

  • SavedMatrix is rewritten to immutable data class.
  • All methods from SavedMatrix are converted to functions (or extension functions).
  • All implementation should work as well, without any regression.

Additional context
This is low priority refactor issue

@Sloox
Copy link
Contributor

Sloox commented Aug 18, 2020

On hold due to a large pull request that is more important and will bring some changes to the class: #919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants