Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all checked in apks to test_artifacts #849

Closed
bootstraponline opened this issue Jun 15, 2020 · 8 comments
Closed

Move all checked in apks to test_artifacts #849

bootstraponline opened this issue Jun 15, 2020 · 8 comments

Comments

@bootstraponline
Copy link
Contributor

Move the apks from
https://github.com/Flank/flank/tree/master/test_app/apks

into the test_artifact repo.
https://github.com/Flank/test_artifacts

Consolidating all binary files in https://github.com/Flank/test_artifacts will ensure that the Flank repo size remains reasonable over time.

@pawelpasterz
Copy link
Contributor

Needs second round of refinement

@bootstraponline
Copy link
Contributor Author

https://firebase-community.slack.com/archives/C72V6UW8M/p1592959060387200

upon further discussion, we should document the pros/cons of a few different options for replacing test_artifacts.

Possible ideas include:

  • Git LFS
  • Git submodules
  • Some other download logic?
  • Other ideas...

@adamfilipow92
Copy link
Contributor

adamfilipow92 commented Jul 6, 2020

Other option is git-annex here is a little comparison between git annex and lfs.

Here is how to install git-lfs: https://git-lfs.github.com
Here is how to install git-annex: https://git-annex.branchable.com/tips/centralized_git_repository_tutorial/on_GitHub/ but little old article

@adamfilipow92 adamfilipow92 self-assigned this Jul 6, 2020
@jan-goral
Copy link
Contributor

jan-goral commented Jul 7, 2020

It's important to choose option that also covers versioning we don't want to always share same artifacts between different branches.

@piotradamczyk5
Copy link
Contributor

@jan-gogo I think that it is solved by test artifacts ? right?

@jan-goral
Copy link
Contributor

@jan-gogo I think that it is solved by test artifacts ? right?

Exactly

@piotradamczyk5
Copy link
Contributor

@jan-gogo I think that it is solved by test artifacts ? right?

Exactly

So I will close the issue

@piotradamczyk5
Copy link
Contributor

Fixed by introducing test_artifacts gradle task.
More info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants