Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the version of Flank on each test run #740

Closed
bootstraponline opened this issue Apr 24, 2020 · 3 comments · Fixed by #757
Closed

Print the version of Flank on each test run #740

bootstraponline opened this issue Apr 24, 2020 · 3 comments · Fixed by #757
Assignees
Milestone

Comments

@bootstraponline
Copy link
Contributor

bootstraponline commented Apr 24, 2020

Users often have no idea what version of Flank they're using. It'd be helpful if each Flank execution printed the current version of flank to stdout before running the tests.

Update Flank to always print a version (instead of the current unknown for local builds)

@bootstraponline bootstraponline added this to the May 2020 milestone Apr 24, 2020
@jan-goral
Copy link
Contributor

@bootstraponline

I can handle that but I have two questions first.

  1. Which version should be print for snapshot. SNAPSHOT will be enough? Or 8.2.0-SNAPSHOT (if next version is 8.2.0).

  2. Question is about revision. The comment suggests that may be commit revision (git rev-parse HEAD) if so, I have no idea how to update revision.txt without creating another commit with different revision and more how to do that automatically on github using Squash and merge button.

@bootstraponline
Copy link
Contributor Author

bootstraponline commented Apr 30, 2020

$ java -jar flank.jar --version
flank_snapshot
8ae4f2b7857640eb46825da5164c2cc0c2828889

^ That's what snapshot currently prints when built on bitrise. Locally we only see unknowns. Ideally local builds would display the same information.

Yes, revision is the git revision. We can fetch this via git status

The idea is if a user builds flank locally, there should be some useful information in the version and revision output.

In CI, bitrise automatically populates this for us.

@jan-goral
Copy link
Contributor

Ok, so locally the revision can by updated automatically by gradle task. I can handle that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants