Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Preserve SkipTestIdentifiers when generating xctestrun #433

Closed
bootstraponline opened this issue Dec 6, 2018 · 6 comments
Closed

Comments

@bootstraponline
Copy link
Contributor

bootstraponline commented Dec 6, 2018

xctestrun file generated by Xcode includes tests in SkipTestIdetifiers section, i.e.:

<key>SkipTestIdentifiers</key>
<array>
  <string>a/b</string>
</array>

Flank incorrectly strips the SkipTestIdentifiers section.

@ceaglest
Copy link

ceaglest commented Dec 6, 2018

+1, I have ran into this issue as well. Our current workaround is to comment out skipped tests in code instead of using SkipTestIdentifiers.

@paynerc
Copy link

paynerc commented Dec 6, 2018

@ceaglest I should have known you would comment as soon as I sent you the link. 😆

But yet, this would be a super awesome fix for us.

@bootstraponline
Copy link
Contributor Author

Our current workaround is to comment out skipped tests in code

That's what we've been doing at Instructure. I'll try and get this fixed in the next Flank release.

@bootstraponline
Copy link
Contributor Author

I added a test, it looks like SkipTestIdentifiers is being preserved.

@ceaglest @paynerc Would you help me reproduce the bug by providing your xctestrun files? For bonus points, modify the JUnit test in this PR to fail.

#434

@bootstraponline
Copy link
Contributor Author

Fixed in #435

The snapshot jar is building now. Try it and let me know if the issue still exists.

https://github.com/TestArmada/flank/releases/tag/flank_snapshot

@ceaglest
Copy link

ceaglest commented Dec 8, 2018

We are consuming 4.1.1 and it is working well for dynamically generated test cases and a sharding factor of 1.

We will try using SkipTestIdentifiers next week. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants