-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS - Preserve SkipTestIdentifiers when generating xctestrun #433
Comments
+1, I have ran into this issue as well. Our current workaround is to comment out skipped tests in code instead of using |
@ceaglest I should have known you would comment as soon as I sent you the link. 😆 But yet, this would be a super awesome fix for us. |
That's what we've been doing at Instructure. I'll try and get this fixed in the next Flank release. |
Fixed in #435 The snapshot jar is building now. Try it and let me know if the issue still exists. https://github.com/TestArmada/flank/releases/tag/flank_snapshot |
We are consuming 4.1.1 and it is working well for dynamically generated test cases and a sharding factor of 1. We will try using SkipTestIdentifiers next week. Thank you! |
xctestrun
file generated by Xcode includes tests inSkipTestIdetifiers
section, i.e.:Flank incorrectly strips the
SkipTestIdentifiers
section.The text was updated successfully, but these errors were encountered: