Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data scratch - orientations #1749

Closed
jan-goral opened this issue Mar 29, 2021 · 0 comments · Fixed by #1820
Closed

Data scratch - orientations #1749

jan-goral opened this issue Mar 29, 2021 · 0 comments · Fixed by #1820

Comments

@jan-goral
Copy link
Contributor

Plan

According to the specification described in epic #1727
add abstraction and implementation for the following part of the data layer:

Abstraction

ftl/data/Orientation.kt

package ftl.data

val fetchOrientation: Orientation.Fetch get() = TODO()

data class Orientation(
    val id: String,
    val name: String,
    val tags: String,
) {
    interface Fetch : (projectId: String, platform: String) -> List<Orientation>
}

Target

  • AndroidOrientationsListCommand -> AndroidCatalog/supportedOrientationsAsTable -> AndroidCatalog/deviceCatalog
  • IosOrientationsListCommand -> IosCatalog/supportedOrientationsAsTable -> IosCatalog/iosDeviceCatalog

Adapter

ftl/adapter/GoogleOrientationFetch.kt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants