Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move publishing flank-scripts from bintray to other place #1565

Closed
piotradamczyk5 opened this issue Feb 4, 2021 · 2 comments · Fixed by #1618
Closed

Move publishing flank-scripts from bintray to other place #1565

piotradamczyk5 opened this issue Feb 4, 2021 · 2 comments · Fixed by #1618
Assignees
Milestone

Comments

@piotradamczyk5
Copy link
Contributor

piotradamczyk5 commented Feb 4, 2021

Author the user story for this feature

As a Developer, I want to upload flank-scripts to maven repository with direct link so I can download it when needed.

Describe the solution
Currently, we are uploading flank-scripts to bintray which will be closed at the end of April, so we should found another place to store flank-scripts binaries.

Please update also flank-scripts download task

tasks.register("download") {
    val sourceUrl = "https://dl.bintray.com/flank/maven/com/github/flank/$artifactID/$version/$artifactID-$version.jar"
    val destinationFile = Paths.get("bash", "flank-scripts.jar").toFile()
    ant.invokeMethod("get", mapOf("src" to sourceUrl, "dest" to destinationFile))
}

Requirements

  1. Free
  2. Easy to upload and download
  3. Possibility to get a direct link to download jar

Possible solutions

Describe alternatives considered
As an alternative, we could upload flank-scripts to Github packages and get a link through Github API, but it needs one additional request with parsing output

@bootstraponline
Copy link
Contributor

my preference is to use the github maven repo https://github.com/features/packages

github is unlikely to go away

jitpack could disappear in the same way jcenter did

@piotradamczyk5 piotradamczyk5 self-assigned this Feb 15, 2021
@zuziaka zuziaka added this to the Sprint 2 milestone Feb 15, 2021
@piotradamczyk5
Copy link
Contributor Author

piotradamczyk5 commented Feb 16, 2021

@bootstraponline I see your point of view, but please notice, that flank-scripts is just used internally by our team.
What is more, we do not use it as Gradle dependency, but as a bash program, so we just need to download the right jar for it.
Github packages do not have a direct link to download jar as well as API to retrieve it, so for this particular case I think we should add it to jitpack to use it as easy as possible

EDIT:
I will publish flank-scripts to both github release and github packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants