Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: flankScripts is failing on windows os #1237

Closed
jan-goral opened this issue Oct 13, 2020 · 2 comments · Fixed by #1250
Closed

Bug: flankScripts is failing on windows os #1237

jan-goral opened this issue Oct 13, 2020 · 2 comments · Fixed by #1250
Assignees

Comments

@jan-goral
Copy link
Contributor

Describe the bug
The flankScripts are not working on windows OS.
Gives different errors for native windows and WSL

To Reproduce

  1. Create a new pull request
  2. See errors like lined above

Expected behavior
Both workflows should passes like for ubuntu and macos.

@Sloox
Copy link
Contributor

Sloox commented Oct 14, 2020

@jan-gogo It appears that we need to have some discussion around it.
For now what shall we do with the pull requests that will always fail.
Shall we manually merge them?
WDYT?

@Sloox
Copy link
Contributor

Sloox commented Oct 14, 2020

Thinking about this task may require us to check in the gradle script which OS we running on and run different tasks.
https://mrhaki.blogspot.com/2017/02/gradle-goodness-check-operating-system.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants