Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some config options are not printed during test run #1185

Closed
pawelpasterz opened this issue Oct 2, 2020 · 4 comments · Fixed by #1214
Closed

Some config options are not printed during test run #1185

pawelpasterz opened this issue Oct 2, 2020 · 4 comments · Fixed by #1214
Assignees
@piotradamczyk5
Labels
Bug Feature Snake 🐍 Tech Debt

Comments

@pawelpasterz
Copy link
Contributor

pawelpasterz commented Oct 2, 2020 •
edited
Loading

There are some configuration options that are not printed with flank run:

  1. disable-results-upload
  2. default-test-time
  3. default-class-test-time
  4. (can be more, needs to be verified)

Are those not printed intentionally?

  • No we should verify the remaining options and add to the printing logic
  • Yes then we should decide how to hide them? Even though not printed it is still possible to set them via yml file
@pawelpasterz
Copy link
Contributor Author

@bootstraponline @adamfilipow92 @piotradamczyk5 @axelzuziak-gogo @Sloox @jan-gogo

@bootstraponline
Copy link
Contributor

The only option not printed intentionally is environment variables. Everything else should be printed.

@piotradamczyk5
Copy link
Contributor

default-test-time is printed 😄

@pawelpasterz
Copy link
Contributor Author

default-test-time is printed 😄

removed

@piotradamczyk5 piotradamczyk5 self-assigned this Oct 5, 2020
@piotradamczyk5 piotradamczyk5 mentioned this issue Oct 5, 2020
Merged
3 tasks
@mergify mergify bot closed this as completed in #1214 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotradamczyk5 piotradamczyk5

Labels
Bug Feature Snake 🐍 Tech Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Added printing missing options Flank/flank
3 participants
@bootstraponline @pawelpasterz @piotradamczyk5