Always dump shards follow up and fixes

[pawelpasterz]

Describe the bug

A clear and concise description of what the bug is.

Major problems:

1. flank downloads, parses and calculates shards twice (dump shards and test run)
2. flank run with only robo test (including sanity robo) is broken

version: local_snapshot
revision: 7ab394646734d47b6d48753a06c119de323426d0

Cannot dump shards for non instrumentation test, ensure test apk has been set.

3. Strange, duplicated shards output

version: local_snapshot
revision: 7ab394646734d47b6d48753a06c119de323426d0

 Smart Flank cache hit: 0% (0 / 11)
  Shard times: 1065s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s

Saved 6 shards to android_shards.json

[long flank config]

RunTests

 Smart Flank cache hit: 0% (0 / 11)
  Shard times: 1065s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s


 Smart Flank cache hit: 0% (0 / 9)
  Shard times: 1035s

  Uploading app-debug.apk .
  Uploading app-multiple-error-debug-androidTest.apk .  Uploading app-multiple-success-debug-androidTest.apk .  Uploading app-multiple-flaky-debug-androidTest.apk .

To Reproduce

Steps to reproduce the behavior:

1. Run any test run

Expected behavior

A clear and concise description of what you expected to happen.

1. We should reuse calculated shards
2. robo tests should be working
3. Output should not be duplicated

Details (please complete the following information):

Have you tested on the latest Flank snapshot?

Post the output of flank --version.

version: local_snapshot
revision: 7ab394646734d47b6d48753a06c119de323426d0