From c9926e981377f94356b2763a9d278196b507ee85 Mon Sep 17 00:00:00 2001 From: Pawel Pasterz Date: Mon, 3 Aug 2020 15:31:21 +0200 Subject: [PATCH] Add comment in code --- test_runner/src/main/kotlin/ftl/json/SavedMatrix.kt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test_runner/src/main/kotlin/ftl/json/SavedMatrix.kt b/test_runner/src/main/kotlin/ftl/json/SavedMatrix.kt index 1a05f975bf..3e32ded329 100644 --- a/test_runner/src/main/kotlin/ftl/json/SavedMatrix.kt +++ b/test_runner/src/main/kotlin/ftl/json/SavedMatrix.kt @@ -148,9 +148,11 @@ class SavedMatrix(matrix: TestMatrix) { flakyOutcome: Boolean ) { outcome = when { - // the matrix outcome is failure if any step fails - // if the matrix outcome is already set to failure then we can ignore the other step outcomes. - // inconclusive is treated as a failure + // The matrix outcome is failure if any step fails + // If the matrix outcome is already set to failure then we can ignore the other step outcomes. + // Inconclusive is treated as a failure + // This particular conditions order should not be changed, for more details check: + // https://github.com/Flank/flank/issues/914 outcome == failure || outcome == inconclusive -> return flakyOutcome -> flaky outcome == flaky -> this?.summary?.takeIf { it == failure || it == inconclusive }