From c43ce42ed867cea393eeeb45574b789f50b27440 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janek=20G=C3=B3ral?= Date: Tue, 23 Mar 2021 13:24:34 +0100 Subject: [PATCH] update --- docs/refactor/investigation.md | 6 +++--- docs/refactor/proposal.md | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/refactor/investigation.md b/docs/refactor/investigation.md index 22a5d71e3b..f74e3de252 100644 --- a/docs/refactor/investigation.md +++ b/docs/refactor/investigation.md @@ -15,7 +15,7 @@ This document is and entity point for further improvements. #### Issues -1. `ftl.Main` command shouldn't be bound with `main` function with constructor +1. `ftl.Main` command shouldn't be bound with `main` function through companion object due to single responsibility principle. 1. Some commands that can run domain code are doing too much. 1. Some of composing commands seem to be in wrong package. @@ -103,7 +103,7 @@ command that: 1. The domain layer of flank is not clearly separated of CLI and external APIs. 1. Domain logic is huge and complicated but there is lack of diagram for visualize it. -### Data [ consider better name ] +### Data & Adapters #### Issues @@ -525,4 +525,4 @@ where * `IArgs.uploadIfNeeded` -> `FileReference.uploadIfNeeded` -> `GcStorage.upload` * `GcIosTestMatrix/build` * `AbstractGoogleJsonClientRequest/executeWithRetry` - * `IArgs/afterRunTests` - the rest of steps are same as for android \ No newline at end of file + * `IArgs/afterRunTests` - the rest of steps are same as for android diff --git a/docs/refactor/proposal.md b/docs/refactor/proposal.md index 2b6e86acd8..6fa4f001d0 100644 --- a/docs/refactor/proposal.md +++ b/docs/refactor/proposal.md @@ -1,4 +1,4 @@ -# Flank refactor proposal [Not complete] +# Flank refactor proposal ## Motivation @@ -36,8 +36,8 @@ but from technical perspective those will be interfaces, type aliases, and struc * ftl * cli * domain - * data ? - * adapters ? + * data + * adapters * utils @@ -107,4 +107,4 @@ which will be a bridge between domain and external APIs. * New package for grouping wrappers and adapters for external APIs. * Consider separated package in `ftl` only for interfaces and structures, shared between api adapters and domain. -* External API structures and function cannot leak to other layers. \ No newline at end of file +* External API structures and function cannot leak to other layers.