From 4b277ca3bd17c75066e442f5c291b23c2c1e7da4 Mon Sep 17 00:00:00 2001 From: Carlos Sessa Date: Sun, 27 Jan 2019 17:11:54 -0600 Subject: [PATCH] Fix after testing in real app --- test_runner/src/main/kotlin/ftl/args/IosArgs.kt | 3 --- .../src/test/kotlin/ftl/args/IosArgsFileTest.kt | 10 +++++----- .../src/test/kotlin/ftl/fixtures/flank2.ios.yml | 7 +------ 3 files changed, 6 insertions(+), 14 deletions(-) diff --git a/test_runner/src/main/kotlin/ftl/args/IosArgs.kt b/test_runner/src/main/kotlin/ftl/args/IosArgs.kt index 1718cb1e8c..504dbb1a95 100644 --- a/test_runner/src/main/kotlin/ftl/args/IosArgs.kt +++ b/test_runner/src/main/kotlin/ftl/args/IosArgs.kt @@ -6,7 +6,6 @@ import ftl.args.ArgsHelper.createGcsBucket import ftl.args.ArgsHelper.createJunitBucket import ftl.args.ArgsHelper.evaluateFilePath import ftl.args.ArgsHelper.mergeYmlMaps -import ftl.args.ArgsHelper.validateTestMethods import ftl.args.ArgsHelper.yamlMapper import ftl.args.ArgsToString.devicesToString import ftl.args.ArgsToString.listToString @@ -65,8 +64,6 @@ class IosArgs( if (disableSharding) return@lazy listOf(emptyList()) val validTestMethods = Xctestrun.findTestNames(xctestrunFile) - validateTestMethods(testTargets, validTestMethods, "xctest binary") - val testsToShard = filterTests(validTestMethods, testTargets).distinct() ArgsHelper.calculateShards(testsToShard, this) diff --git a/test_runner/src/test/kotlin/ftl/args/IosArgsFileTest.kt b/test_runner/src/test/kotlin/ftl/args/IosArgsFileTest.kt index 0fcc095d4d..15b9d1e98a 100644 --- a/test_runner/src/test/kotlin/ftl/args/IosArgsFileTest.kt +++ b/test_runner/src/test/kotlin/ftl/args/IosArgsFileTest.kt @@ -70,15 +70,15 @@ class IosArgsFileTest { val chunk0 = arrayListOf( "EarlGreyExampleSwiftTests/testWithGreyAssertions", - "EarlGreyExampleSwiftTests/testLayout", - "EarlGreyExampleSwiftTests/testThatThrows", - "EarlGreyExampleSwiftTests/testWithCondition" + "EarlGreyExampleSwiftTests/testWithInRoot", + "EarlGreyExampleSwiftTests/testWithCondition", + "EarlGreyExampleSwiftTests/testWithCustomFailureHandler" ) val chunk1 = arrayListOf( "EarlGreyExampleSwiftTests/testWithGreyAssertions", - "EarlGreyExampleSwiftTests/testWithInRoot", - "EarlGreyExampleSwiftTests/testCustomAction" + "EarlGreyExampleSwiftTests/testWithCustomMatcher", + "EarlGreyExampleSwiftTests/testWithCustomAssertion" ) val testShardChunks = config.testShardChunks diff --git a/test_runner/src/test/kotlin/ftl/fixtures/flank2.ios.yml b/test_runner/src/test/kotlin/ftl/fixtures/flank2.ios.yml index e58119e537..1fff8c552c 100644 --- a/test_runner/src/test/kotlin/ftl/fixtures/flank2.ios.yml +++ b/test_runner/src/test/kotlin/ftl/fixtures/flank2.ios.yml @@ -15,11 +15,6 @@ flank: testShards: 2 repeatTests: 1 test-targets: - - EarlGreyExampleSwiftTests/testWithGreyAssertions - - EarlGreyExampleSwiftTests/testLayout - - EarlGreyExampleSwiftTests/testThatThrows - - EarlGreyExampleSwiftTests/testWithInRoot - - EarlGreyExampleSwiftTests/testCustomAction - - EarlGreyExampleSwiftTests/testWithCondition + - EarlGreyExampleSwiftTests/testWith.*$ test-targets-always-run: - EarlGreyExampleSwiftTests/testWithGreyAssertions