Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift and drag are not correct in internal evaluators. #154

Closed
KlyithSA opened this issue Nov 26, 2024 · 0 comments
Closed

Lift and drag are not correct in internal evaluators. #154

KlyithSA opened this issue Nov 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@KlyithSA
Copy link

The fallback evaluators for lift, drag, and terminal velocity used when FAR is not installed are wildly incorrect. I noticed that they cite NathalKell's AeroGUI as the source, but made a small error when porting the code such that lift modules would never be checked. (The if !p.hasLiftModule block was not closed, so the loop to evaluate lift modules only happens in parts that don't have lift modules.)

Made PR #153 to fix this.

I can only assume that nobody has noticed this for years because everyone who cares about lift and drag numbers uses FAR. :)

@KlyithSA KlyithSA added the bug Something isn't working label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants