Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate base RequestInterface #48

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Deprecate base RequestInterface #48

merged 2 commits into from
Jun 5, 2018

Conversation

Firehed
Copy link
Owner

@Firehed Firehed commented Jun 5, 2018

Fixes #47

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #48 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
+ Coverage     95.84%   95.94%   +0.09%     
- Complexity       95       96       +1     
============================================
  Files            23       23              
  Lines           289      296       +7     
============================================
+ Hits            277      284       +7     
  Misses           12       12
Impacted Files Coverage Δ Complexity Δ
src/Dispatcher.php 98.9% <100%> (+0.09%) 30 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd650e1...a447071. Read the comment docs.

@Firehed Firehed merged commit 4b01a56 into master Jun 5, 2018
@Firehed Firehed deleted the base_request_warning branch June 5, 2018 05:39
Firehed added a commit that referenced this pull request Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant