-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable custom querier #118
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 63.37% 63.48% +0.11%
==========================================
Files 80 80
Lines 9954 9934 -20
==========================================
- Hits 6308 6307 -1
+ Misses 3315 3297 -18
+ Partials 331 330 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changelog.
Sorry, I missed to stage the change. Thanks for your found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR closes the custom querier for other modules.
closes: #115
Motivation and context
Since Finschia/finschia-sdk@0f4ad5b, custom query is opened for our token/collection module.
It is not as expected this is still alive after we separate x/wasm and x/wasmplus.
So this PR deletes it.
Alternative queries for our original modules are going to be opened with the stargate query feature in later versions.
How has this been tested?
After merging, the default custom querier is the same as upstream.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml
(not needed)