Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable custom querier #118

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

loloicci
Copy link

Description

This PR closes the custom querier for other modules.

closes: #115

Motivation and context

Since Finschia/finschia-sdk@0f4ad5b, custom query is opened for our token/collection module.
It is not as expected this is still alive after we separate x/wasm and x/wasmplus.
So this PR deletes it.

Alternative queries for our original modules are going to be opened with the stargate query feature in later versions.

How has this been tested?

After merging, the default custom querier is the same as upstream.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. (not needed)
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.48%. Comparing base (0b88522) to head (7d29019).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   63.37%   63.48%   +0.11%     
==========================================
  Files          80       80              
  Lines        9954     9934      -20     
==========================================
- Hits         6308     6307       -1     
+ Misses       3315     3297      -18     
+ Partials      331      330       -1     
Files Coverage Δ
x/wasm/keeper/query_plugins.go 79.48% <100.00%> (+3.35%) ⬆️

@loloicci loloicci marked this pull request as ready for review February 26, 2024 09:24
@loloicci loloicci requested a review from zemyblue February 26, 2024 09:24
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog.

@loloicci
Copy link
Author

loloicci commented Feb 26, 2024

Please add changelog.

Sorry, I missed to stage the change. Thanks for your found!

Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit bf97dea into Finschia:main Feb 26, 2024
12 checks passed
@loloicci loloicci deleted the disable-custom-query branch February 26, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is the difference between Custom and Stargate querier?
3 participants