fix: replace query errors on the original modules into gRPC ones #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc/v0.47.0-alpha1 #956 +/- ##
=====================================================
+ Coverage 62.43% 62.49% +0.06%
=====================================================
Files 655 655
Lines 79794 79921 +127
=====================================================
+ Hits 49820 49950 +130
+ Misses 27289 27287 -2
+ Partials 2685 2684 -1
|
zemyblue
reviewed
Apr 8, 2023
zemyblue
reviewed
Apr 8, 2023
zemyblue
approved these changes
Apr 8, 2023
3 tasks
0Tech
added a commit
to 0Tech/finschia-sdk
that referenced
this pull request
Apr 12, 2023
5 tasks
0Tech
added a commit
that referenced
this pull request
Apr 13, 2023
* Do not check existence of collection in Query/Balance * Update CHANGELOG.md * Revert "Update CHANGELOG.md" This reverts commit 00b8bc2. * Revert "Do not check existence of collection in Query/Balance" This reverts commit 029c26a. * Revert #956 on x/auth relevant checks * Add asset check on Query/HoldersByOperator * Wrap non stateful errors with InvalidArgument * Revert gRPC errors on page error * Update CHANGELOG.md * Increase coverage
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Apr 21, 2023
* rc/v0.47.0-alpha1: (34 commits) ci: update docker action (Finschia#983) fix: revert Finschia#952 (Finschia#984) refactor: refactor x/token,collection query errors (Finschia#980) fix: not to throw error when no txs in block (Finschia#982) chore: change import path to `github.com/Finschia/finschia-sdk` (Finschia#970) fix: remove legacy events on x/collection and x/token (Finschia#966) chore: provide specific error messages on x/collection queries (Finschia#965) fix: check event determinism on original modules (Finschia#963) fix: refactor queries of x/collection and x/token (Finschia#957) chore: address generation of the empty coins in x/foundation (Finschia#952) fix: do not loop enum in x/collection (Finschia#961) fix: fix default next class ids of x/collection (Finschia#960) fix: revert Finschia#955 and add Query/HasParent into x/collection (Finschia#959) fix: replace query errors on the original modules into gRPC ones (Finschia#956) fix: return nil where the parent not exists in x/collection Query/Parent (Finschia#955) fix: remove duplicated events in x/collection Msg/Modify (Finschia#954) fix: allow zero amount of coin in x/collection Query/Balance (Finschia#953) fix: unpack proposals in x/foundation import-genesis (Finschia#947) fix: fix broken x/foundation invariant on treasury (Finschia#946) docs: update comments in the x/token,collection events proto (Finschia#944) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would replace previous errors on queries into gRPC ones.
"Almost" all gRPC queries on x/token and x/collection would return NotFound, where
CAUTION: this will break the compatibility with Daphne on queries.
Motivation and context
Our client wants the errors on gRPC interface to have the right error code on
NotFound.Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml