fix: fix the compatibility issues with daphne #539
Conversation
There was a problem hiding this comment.
Thank you for your review @ryu1-sakai, I've added my replies.
After pushing my works, I will apply your opinion.
Codecov Report
@@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 57.59% 57.69% +0.09%
==========================================
Files 793 793
Lines 86584 87013 +429
==========================================
+ Hits 49866 50198 +332
- Misses 33558 33658 +100
+ Partials 3160 3157 -3
|
There was a problem hiding this comment.
@0Tech, I wrote two questions and one comment about event.proto.
proto/lbm/token/v1/query.proto
Outdated
| } | ||
|
|
||
| // Authorization queries authorization on a given operator holder pair. | ||
| // if no authorization found for the request, it would return an error. |
There was a problem hiding this comment.
Could you write the comment to explain what kind of error clients will receive when no authorization is found?
Client need to distinguish such a not-found error from other kind of errors.
There was a problem hiding this comment.
I updated the comment.
There was a problem hiding this comment.
Thank you, I confirmed the comments! 👍
* Charge gas for custom event attributes * Introduce gas register for gas costs * Review feedback * Tests and minor updates * Godoc
Description
ref: #412
Motivation and context
The module was not compatible with the legacy one, and we concluded to maintain the most part of the interface.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml