Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/fbridge): set target denom as module parameters #1366

Merged
merged 6 commits into from
May 8, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented May 8, 2024

Description

closes: #XXXX

  • Set fbridge target denom as module parameters
  • Add UpdateParams to be able to change this value in the future.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@tkxkd0159 tkxkd0159 added the A: feature New features label May 8, 2024
@tkxkd0159 tkxkd0159 self-assigned this May 8, 2024
@tkxkd0159 tkxkd0159 added the A: improvement Changes in existing functionality label May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 29.54545% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 69.50%. Comparing base (5e2cd7f) to head (be50a04).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   69.53%   69.50%   -0.04%     
==========================================
  Files         672      672              
  Lines       56111    56154      +43     
==========================================
+ Hits        39019    39029      +10     
- Misses      14827    14858      +31     
- Partials     2265     2267       +2     
Files Coverage Δ
simapp/app.go 80.06% <100.00%> (ø)
x/fbridge/keeper/keeper.go 72.09% <100.00%> (-0.33%) ⬇️
x/fbridge/keeper/params.go 86.66% <100.00%> (+3.33%) ⬆️
x/fbridge/keeper/transfer.go 74.54% <100.00%> (ø)
x/fbridge/types/codec.go 54.28% <50.00%> (-0.26%) ⬇️
x/fbridge/types/genesis.go 0.00% <0.00%> (ø)
x/fbridge/keeper/genesis.go 8.47% <0.00%> (-1.88%) ⬇️
x/fbridge/types/msgs.go 0.00% <0.00%> (ø)
x/fbridge/types/params.go 38.88% <0.00%> (-3.54%) ⬇️
x/fbridge/keeper/msg_server.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@tkxkd0159 tkxkd0159 requested a review from jaeseung-bae May 8, 2024 15:59
@tkxkd0159 tkxkd0159 merged commit a9be0cb into main May 8, 2024
45 of 46 checks passed
@tkxkd0159 tkxkd0159 deleted the target-denom-params branch May 8, 2024 16:12
mergify bot pushed a commit that referenced this pull request May 8, 2024
* set fbridge target denom through params

* add UpdateParams

* add event and unittest

* use sdk denom checker

(cherry picked from commit a9be0cb)
tkxkd0159 added a commit that referenced this pull request May 8, 2024
* set fbridge target denom through params

* add UpdateParams

* add event and unittest

* use sdk denom checker

(cherry picked from commit a9be0cb)

Co-authored-by: Jaeseung Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: feature New features A: improvement Changes in existing functionality backport/v0.49.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants