feat: introduce new modules(fswap, fbridge) #1352

jaeseung-bae · 2024-05-03T13:23:45Z

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

* feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]>

* feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]>

* initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature

* impl bridge transfer tx/query * add CLI

* feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums

…Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]>

codecov · 2024-05-03T13:30:55Z

Codecov Report

Attention: Patch coverage is 36.04294% with 417 lines in your changes are missing coverage. Please review.

Project coverage is 69.98%. Comparing base (55b6566) to head (956d7a6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
- Coverage   70.38%   69.98%   -0.40%     
==========================================
  Files         643      663      +20     
  Lines       54793    55440     +647     
==========================================
+ Hits        38564    38800     +236     
- Misses      14054    14407     +353     
- Partials     2175     2233      +58

Files	Coverage Δ
simapp/app.go	`80.06% <100.00%> (+0.89%)`	⬆️
x/fswap/keeper/calc.go	`100.00% <100.00%> (ø)`
x/fswap/keeper/keys.go	`100.00% <100.00%> (ø)`
x/fswap/handler.go	`77.77% <77.77%> (ø)`
x/fswap/types/config.go	`0.00% <0.00%> (ø)`
x/fbridge/keeper/keeper.go	`50.00% <50.00%> (ø)`
x/fswap/keeper/msg_server.go	`60.00% <60.00%> (ø)`
x/fswap/module_simulation.go	`9.09% <9.09%> (ø)`
x/fswap/types/codec.go	`41.17% <41.17%> (ø)`
x/fswap/types/genesis.go	`36.84% <36.84%> (ø)`
... and 11 more

... and 1 file with indirect coverage changes

* feat: initialize fswap module (Finschia#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (Finschia#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (Finschia#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (Finschia#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (Finschia#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

* feat: introduce new modules(fswap, fbridge) (#1352) * feat: initialize fswap module (#1336) * feat: initial fswap module Signed-off-by: 170210 <[email protected]> * chore: correct dependencies Signed-off-by: 170210 <[email protected]> * chore: remove unuse files Signed-off-by: 170210 <[email protected]> * feat: add proto files Signed-off-by: 170210 <[email protected]> * chore: make proto-gen Signed-off-by: 170210 <[email protected]> * chore: fix compile error Signed-off-by: 170210 <[email protected]> * chore: add new field in params proto Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * feat: add query&tx commands of fswap module Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> * docs: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * docs: fix error docs Signed-off-by: 170210 <[email protected]> * fix: fix consensusversion Signed-off-by: 170210 <[email protected]> * fix: remove route,type&getSignBytes in msgs.go Signed-off-by: 170210 <[email protected]> * fix: update proto files Signed-off-by: 170210 <[email protected]> * fix: fix NewKeeper Signed-off-by: 170210 <[email protected]> * fix: fix for comment Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: implement fswap module's genesis and params (#1339) * feat: implement genesis related functions Signed-off-by: 170210 <[email protected]> * chore: use mockgen Signed-off-by: 170210 <[email protected]> * chore: add tests Signed-off-by: 170210 <[email protected]> * fix: add subspace in paramsKeeper Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix for test errors Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix appmodulebasic Signed-off-by: 170210 <[email protected]> * chore: update CHANGLOG.md Signed-off-by: 170210 <[email protected]> * fix: use configuration instead of params Signed-off-by: 170210 <[email protected]> * chore: refactor new&default fswapped Signed-off-by: 170210 <[email protected]> * fix: add total_supply into genesisStatus & remove calculate logic Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: fix module_simulation Signed-off-by: 170210 <[email protected]> * fix: set swappableNewCoinDenom as params Signed-off-by: 170210 <[email protected]> * fix: change total_supply name to swappableNewCoinAmount Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: use io/collection to generate key Signed-off-by: 170210 <[email protected]> * Revert "fix: use io/collection to generate key" This reverts commit e42e064. * fix: change sdk.Coin to sdk.Int Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: remote unnecessary codes Signed-off-by: 170210 <[email protected]> * fix: add validate for swappable new coin Signed-off-by: 170210 <[email protected]> * fix: add randomizedGenState Signed-off-by: 170210 <[email protected]> * fix: fix error doc Signed-off-by: 170210 <[email protected]> * fix: fix lint Signed-off-by: 170210 <[email protected]> * fix: change proto message fields' name Signed-off-by: 170210 <[email protected]> --------- Signed-off-by: 170210 <[email protected]> * feat: initialize fbridge module (#1340) * initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature * feat: fbridge transfer (#1347) * impl bridge transfer tx/query * add CLI * feat: save sequence for every bridge request (#1351) * feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums * feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345) * refactor: fswap module's proto Signed-off-by: 170210 <[email protected]> * refactor: remove config&params and modify genesis Signed-off-by: 170210 <[email protected]> * refactor: use gov/proposal to change fswapInit Signed-off-by: 170210 <[email protected]> * chore: fix simulation Signed-off-by: 170210 <[email protected]> * chore: correct query cli Signed-off-by: 170210 <[email protected]> * chore: add query for test Signed-off-by: 170210 <[email protected]> * chore: lint fix * chore: fix for tx cli * chore: update proto * chore: update genesis logic * chore: add basic tx and queries * chore: rename fswap to swap * chore: change old/new to from/to * chore: clean-up * chore: clean errors and rename * chore: update proto * chore: clean unnecessary member variables * chore: update proto, introduce config, clean code * chore: remove redundant denom validation * chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2 * chore: apply feedbacks * chore: fix some * chore: fix for initGenesis * chore: apply feedbacks * chore: update changelog * chore: remove redundant logic * chore: update error doc * chore: update proto and logic to accept bank.Metadata * chore: add query to get all the swaps * chore: change swap_multiple to swap_rate * chore: disallow updating existing denom metadata with different values * chore: fix for calcSwap logic * chore: extract CalcSwap to function * chore: add missing query cmd * chore: fix for proposal cli * chore: fix for init timing * chore: fix query cli * chore: fix to prevent generating swap more than MaxSwaps * fix: add missing call validateBasic for proposal * fix: * chore: change error type for temporal test-pass * chore: fix for make-swap-proposal update * chore: fix to check swap count after increase in order not to make more than limit * chore: prevent any proposal with different denom * chore: change amount cap type * chore: fix codec-related parts * chore: minor change for convert to-coin-amount-cap --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: jaeseung.bae <[email protected]> --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]> * chore: lint fix --------- Signed-off-by: 170210 <[email protected]> Co-authored-by: 170210 <[email protected]> Co-authored-by: Jayden Lee <[email protected]>

170210 and others added 6 commits April 18, 2024 16:33

feat: initialize fbridge module (#1340)

82e8936

* initialize fbridge module * add all proto files for fbridge * add missing proto files * initialize module structure * modify proto based on discussion * add codec * add CHANGELOG * modify UpdateRole feature

feat: fbridge transfer (#1347)

7b421db

* impl bridge transfer tx/query * add CLI

feat: save sequence for every bridge request (#1351)

8d79d25

* feat: add SeqToBlocknum * add CHANGELOG * add query bound for SeqToBlocknums

jaeseung-bae added A: State Machine Breaking Any changes that result in a different AppState given same genesisState and txList. A: feature New features labels May 3, 2024

jaeseung-bae marked this pull request as ready for review May 3, 2024 13:24

jaeseung-bae requested review from tkxkd0159, zemyblue and 0Tech as code owners May 3, 2024 13:24

zemyblue approved these changes May 3, 2024

View reviewed changes

0Tech approved these changes May 3, 2024

View reviewed changes

jaeseung-bae merged commit b73fabd into main May 3, 2024
51 of 52 checks passed

jaeseung-bae mentioned this pull request May 7, 2024

feat: introduce new modules(fswap, fbridge) (backport #1352) #1357

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: introduce new modules(fswap, fbridge) #1352

feat: introduce new modules(fswap, fbridge) #1352

jaeseung-bae commented May 3, 2024

codecov bot commented May 3, 2024

feat: introduce new modules(fswap, fbridge) #1352

feat: introduce new modules(fswap, fbridge) #1352

Conversation

jaeseung-bae commented May 3, 2024

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov bot commented May 3, 2024

Codecov Report